chore: Update otel smoke tests

[mnkiefer]

• Updates the smoke test workflows for OTEL backends, focusing on improving the clarity and actionability of failure reporting.
• Removes obsolete generic OTEL smoke test workflow.

[mnkiefer]

@copilot Recompile workflow

[github-actions]

✅ smoke-ci: safeoutputs CLI comment + comment-memory run (25958878668)

Generated by 🧪 Smoke CI for issue #32598 · ◷

[github-actions]

Comment Memory

CI lights the path
Green checks bloom at dawn
Quiet bots still sing

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

Generated by 🧪 Smoke CI for issue #32598 · ◷

[Copilot]

@copilot Recompile workflow

Done — ran a full recompile across all 228 workflows (0 errors, 0 warnings). The smoke-otel-backends.lock.yml is already up to date; only body/instruction text changed in this PR (not the frontmatter), so the compiled YAML output is unchanged.

[Copilot]

Pull request overview

Removes the obsolete generic OTEL smoke test workflow and refines the OTEL backends smoke test’s failure-reporting instructions to produce more actionable, structured results.

Changes:

• Deleted the legacy Smoke OTEL workflow definition (smoke-otel.md) and its compiled lock workflow (smoke-otel.lock.yml).
• Updated smoke-otel-backends.md output requirements to use a per-backend result table plus a dedicated ## Failure Analysis section.

Show a summary per file

File	Description
.github/workflows/smoke-otel.md	Removed obsolete generic OTEL smoke test workflow source.
.github/workflows/smoke-otel.lock.yml	Removed compiled lock workflow for the obsolete Smoke OTEL workflow.
.github/workflows/smoke-otel-backends.md	Updated issue output format to a backend matrix table and structured failure analysis guidance.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 3/3 changed files
• Comments generated: 1

[github-actions]

Skills-Based Review 🧠

Applied /tdd and /zoom-out for this tests-only PR that updates workflow prompt instructions and removes a redundant workflow.

Key Themes

• Coverage gap from deletion: smoke-otel.md tested the local OTLP infrastructure — env vars set, JSONL mirror created, spans written, zero export errors. smoke-otel-backends.md tests remote backend reachability. These are complementary layers; removing the local smoke test means a misconfigured OTLP env (e.g. missing GH_AW_OTLP_ENDPOINTS) could silently pass the backends test (the agent would just report inconclusive). Worth confirming the local checks are now implicitly covered by Step 1 of smoke-otel-backends.md, or adding a note that this coverage is intentionally dropped.

• Table cell notation: [x] / [ ] in Markdown table cells renders as literal text, not checkboxes. Emoji (✅/❌) would be more readable. (Inline comment added.)

• Agent ordering under budget pressure: With max-continuations: 1, the agent may deprioritise Grafana if Sentry investigation is expensive. The new "do not stop after first failure" instruction is good, but explicit step ordering would reinforce it. (Inline comment added.)

Positive Highlights

• ✅ The structured table + dedicated ## Failure Analysis subsections are a meaningful improvement over the old flat checklist — much easier for on-call engineers to parse at a glance.
• ✅ Requiring the root cause category (write path / read path / auth / config / propagation / backend itself) is excellent — it eliminates the most common "I don't know where to start" friction in failure triage.
• ✅ Deleting the obsolete smoke-otel.lock.yml alongside smoke-otel.md is clean housekeeping.

Verdict

LGTM with the minor nits above. The deletion of smoke-otel.md deserves a quick confirmation that its local-infrastructure coverage is intentionally retired or absorbed elsewhere.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · ● 6M