Skip to content

Add OTLP header-secret fallback to smoke OTEL backend workflow#32611

Closed
Copilot wants to merge 4 commits into
mainfrom
copilot/fix-otel-backend-smoke-test
Closed

Add OTLP header-secret fallback to smoke OTEL backend workflow#32611
Copilot wants to merge 4 commits into
mainfrom
copilot/fix-otel-backend-smoke-test

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 16, 2026

The OTEL backend smoke run showed remote export failures (401 Unauthorized), which left Sentry unable to observe the current run even though local spans were emitted. The workflow documentation and runtime config were also split across two secret conventions: *_HEADERS vs *_AUTHORIZATION.

  • What changed

    • Moved the smoke workflow’s OTLP config into smoke-otel-backends.md so the backend auth wiring is explicit in the workflow being debugged.
    • Added header fallback logic for both Sentry and Grafana:
      • prefer GH_AW_OTEL_*_HEADERS
      • fall back to GH_AW_OTEL_*_AUTHORIZATION by wrapping it as Authorization=...
    • Updated the required-secrets section to reflect both supported secret shapes.
    • Recompiled smoke-otel-backends.lock.yml to carry the new OTLP env wiring into the generated workflow.
  • Why this is the minimal fix

    • The failing path was export auth, not Sentry query access.
    • This keeps existing *_AUTHORIZATION deployments working while allowing workflows documented with *_HEADERS to authenticate correctly.
    • No behavior changes were made outside the smoke OTEL workflow and its generated lockfile.
  • Security review

    • New optional restricted secrets introduced by this workflow change:
      • GH_AW_OTEL_SENTRY_HEADERS
      • GH_AW_OTEL_GRAFANA_HEADERS
    • These are used only to populate OTLP exporter headers for the existing Sentry and Grafana endpoints; no new actions, containers, or network destinations were added beyond the workflow’s existing observability backends.
  • Example

    observability:
      otlp:
        endpoint:
          - url: ${{ secrets.GH_AW_OTEL_SENTRY_ENDPOINT }}
            headers: "${{ secrets.GH_AW_OTEL_SENTRY_HEADERS || (secrets.GH_AW_OTEL_SENTRY_AUTHORIZATION && format('Authorization={0}', secrets.GH_AW_OTEL_SENTRY_AUTHORIZATION)) }}"
          - url: ${{ secrets.GH_AW_OTEL_GRAFANA_ENDPOINT }}
            headers: "${{ secrets.GH_AW_OTEL_GRAFANA_HEADERS || (secrets.GH_AW_OTEL_GRAFANA_AUTHORIZATION && format('Authorization={0}', secrets.GH_AW_OTEL_GRAFANA_AUTHORIZATION)) }}"

Copilot AI linked an issue May 16, 2026 that may be closed by this pull request
Copilot AI and others added 2 commits May 16, 2026 11:58
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix smoke test for OTEL backends Add OTLP header-secret fallback to smoke OTEL backend workflow May 16, 2026
Copilot AI requested a review from mnkiefer May 16, 2026 12:03
@mnkiefer
Copy link
Copy Markdown
Collaborator

@copilot Using the shared import should be equivalent, revert this change and consider other issues.

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 16, 2026

@copilot Using the shared import should be equivalent, revert this change and consider other issues.

Addressed in b0bff37.

@mnkiefer mnkiefer marked this pull request as ready for review May 16, 2026 12:13
Copilot AI review requested due to automatic review settings May 16, 2026 12:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@mnkiefer mnkiefer closed this May 16, 2026
Copilot stopped work on behalf of mnkiefer due to an error May 16, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Smoke Test: OTEL Backends - 25960953565

3 participants