Prevent Multi-Device Docs Tester from self-terminating during cleanup#32643
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Multi-Device Docs Tester workflow failure
Prevent Multi-Device Docs Tester from self-terminating during cleanup
May 16, 2026
pelikhan
approved these changes
May 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents the Multi-Device Docs Tester workflow from self-terminating during cleanup by removing overly-broad process-kill capabilities and reinforcing PID-file-based shutdown.
Changes:
- Removed
pkill*from the docs tester workflow’s allowed Bash tool patterns. - Tightened cleanup guidance to require PID-file-based shutdown and forbid
pkill -f. - Regenerated compiled workflow lockfile(s) to reflect the updated allowlist/prompt.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/daily-multi-device-docs-tester.md |
Removes pkill* from Bash allowlist and updates cleanup instructions to avoid self-termination. |
.github/workflows/daily-multi-device-docs-tester.lock.yml |
Compiled workflow updated so runtime --allowed-tools no longer includes Bash(pkill*). |
.github/workflows/pr-sous-chef.lock.yml |
Regenerated lockfile metadata/heredoc IDs and minor formatting changes (scope noted in comments). |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 2
| ## Step 6: Cleanup | ||
|
|
||
| Follow the shared **Documentation Server Lifecycle Management** instructions for cleanup (section "Stopping the Documentation Server"). | ||
| Use the shared PID-file cleanup command (`kill $(cat /tmp/gh-aw/server.pid) ...`) and **do not use `pkill -f`**. |
Comment on lines
+1
to
4
| # gh-aw-metadata: {"schema_version":"v3","frontmatter_hash":"f1496174ea1147d0a2b83b8d756c3a246355d211fea8553bbe1e100944ca4083","strict":true,"agent_id":"copilot","agent_model":"gpt-5-mini"} | ||
| # gh-aw-manifest: {"version":1,"secrets":["GH_AW_GITHUB_MCP_SERVER_TOKEN","GH_AW_GITHUB_TOKEN","GH_AW_OTEL_GRAFANA_AUTHORIZATION","GH_AW_OTEL_GRAFANA_ENDPOINT","GH_AW_OTEL_SENTRY_AUTHORIZATION","GH_AW_OTEL_SENTRY_ENDPOINT","GITHUB_TOKEN"],"actions":[{"repo":"actions/checkout","sha":"de0fac2e4500dabe0009e67214ff5f5447ce83dd","version":"v6.0.2"},{"repo":"actions/download-artifact","sha":"3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c","version":"v8.0.1"},{"repo":"actions/github-script","sha":"3a2844b7e9c422d3c10d287c895573f7108da1b3","version":"v9.0.0"},{"repo":"actions/setup-node","sha":"48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e","version":"v6.4.0"},{"repo":"actions/upload-artifact","sha":"043fb46d1a93c77aae656e7c1c64a875d1fc6a0a","version":"v7.0.1"}],"containers":[{"image":"ghcr.io/github/gh-aw-firewall/agent:0.25.46"},{"image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.25.46"},{"image":"ghcr.io/github/gh-aw-firewall/cli-proxy:0.25.46"},{"image":"ghcr.io/github/gh-aw-firewall/squid:0.25.46"},{"image":"ghcr.io/github/gh-aw-mcpg:v0.3.9","digest":"sha256:64828b42a4482f58fab16509d7f8f495a6d97c972a98a68aff20543531ac0388","pinned_image":"ghcr.io/github/gh-aw-mcpg:v0.3.9@sha256:64828b42a4482f58fab16509d7f8f495a6d97c972a98a68aff20543531ac0388"},{"image":"ghcr.io/github/github-mcp-server:v1.0.4"},{"image":"node:lts-alpine","digest":"sha256:d1b3b4da11eefd5941e7f0b9cf17783fc99d9c6fc34884a665f40a06dbdfc94f","pinned_image":"node:lts-alpine@sha256:d1b3b4da11eefd5941e7f0b9cf17783fc99d9c6fc34884a665f40a06dbdfc94f"}]} | ||
| # ___ _ _ | ||
| # / _ \ | | (_) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Multi-Device Docs Tester workflow was repeatedly failing with Claude exit code 143 after successful test execution. Failure logs show the agent invoking
pkill -fduring cleanup, which can terminate its own process and exhaust harness retries.Root cause addressed
pkill*from the workflow’s allowed Bash tool patterns indaily-multi-device-docs-tester.mdso the agent cannot invoke self-destructive process-kill patterns.Cleanup behavior tightened
kill $(cat /tmp/gh-aw/server.pid)) and prohibitpkill -f, aligning with the imported server lifecycle contract.Compiled workflow sync
daily-multi-device-docs-tester.lock.ymlso the runtime allowlist and prompt reflect the new restriction.