Fix cache-memory artifact upload path generation in threat-detection workflows

[Copilot]

The Daily Firewall Logs Collector and Reporter run failed after agent execution due to an invalid actions/upload-artifact path pattern (/tmp/gh-aw/cache-memory/.). This change corrects cache-memory artifact path emission so post-agent artifact upload no longer trips path validation.

• Root cause addressed

  • Updated cache-memory artifact upload generation to stop appending /. to cache directories.
  • This affects threat-detection flows where cache-memory is uploaded for downstream update_cache_memory processing.

• Compiler output alignment

  • Updated threat-detection integration test expectations to match the corrected emitted paths for default and multi-cache configurations.

• Code change (representative)

  // before
  fmt.Fprintf(builder, "          path: %s/.\n", cacheDir)
  
  // after
  fmt.Fprintf(builder, "          path: %s\n", cacheDir)

[Copilot]

Pull request overview

This PR corrects cache-memory artifact upload path generation by removing the trailing /. suffix from emitted actions/upload-artifact paths, and updates related threat-detection integration expectations.

Changes:

• Emits cache-memory artifact upload paths as the cache directory directly.
• Updates threat-detection cache-memory test expectations for default and multi-cache workflows.

Show a summary per file

File	Description
pkg/workflow/cache.go	Updates cache-memory upload-artifact path generation.
pkg/workflow/cache_memory_threat_detection_test.go	Adjusts expected generated workflow path strings in threat-detection integration tests.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

pkg/workflow/cache_memory_threat_detection_test.go:140

• This expectation also still matches the old broken value because strings.Contains does not require the line to end here; path: /tmp/gh-aw/cache-memory-session/. would satisfy this string. Add a negative assertion for the /. path or switch these checks to exact generated YAML line comparisons for the upload-artifact steps.

				"name: cache-memory-session\n          include-hidden-files: true\n          path: /tmp/gh-aw/cache-memory-session",

• Files reviewed: 2/2 changed files
• Comments generated: 2

[pelikhan]

@copilot merge main and recompile

[Copilot]

@copilot merge main and recompile

Done in 2b6d968: merged main into this branch and ran make recompile. The workflow lockfiles are up to date (including daily-firewall-report.lock.yml with the corrected cache-memory artifact path).