Skip to content

Allow bash * in linter-miner workflow#32825

Merged
pelikhan merged 1 commit into
mainfrom
copilot/allow-bash-asterisk-linter-miner
May 17, 2026
Merged

Allow bash * in linter-miner workflow#32825
pelikhan merged 1 commit into
mainfrom
copilot/allow-bash-asterisk-linter-miner

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 17, 2026

The linter-miner agent was failing because it attempted bash commands (e.g. gh discussion list, grep) not covered by the restricted allowlist, causing the agent job to fail at step 31.

Changes

  • .github/workflows/linter-miner.md: Replace the explicit bash allowlist with "*" to permit any bash command, consistent with other workflows (e.g. changeset, daily-news, deep-report).
-  bash:
-    - "find pkg/linters -type d"
-    - "cat cmd/linters/main.go"
-    - "cat /tmp/gh-aw/agent/linters-src.txt"
-    - "cat /tmp/gh-aw/agent/go-linters-skill.txt"
-    - "cat /tmp/gh-aw/agent/prior-linters.json"
-    - "go build:*"
-    - "go test:*"
+  bash:
+    - "*"

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan pelikhan marked this pull request as ready for review May 17, 2026 14:19
Copilot AI review requested due to automatic review settings May 17, 2026 14:19
@pelikhan pelikhan merged commit f4347fc into main May 17, 2026
@pelikhan pelikhan deleted the copilot/allow-bash-asterisk-linter-miner branch May 17, 2026 14:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the linter-miner workflow configuration to prevent agent failures caused by bash commands not present in the current restricted allowlist.

Changes:

  • Replaces the explicit tools.bash allowlist in linter-miner with a global "*" wildcard to permit any bash command.
Show a summary per file
File Description
.github/workflows/linter-miner.md Broadens bash tool permissions from a specific allowlist to a global wildcard to avoid job failures from unlisted commands.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

- "cat /tmp/gh-aw/agent/prior-linters.json"
- "go build:*"
- "go test:*"
- "*"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants