Increase default repo-memory MaxFileSize from 10KB to 100KB#32826
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
May 17, 2026 14:18
View session
pelikhan
approved these changes
May 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Increases the default repo-memory maximum file size from 10KB to 100KB and updates related schema/test expectations.
Changes:
- Added a shared
defaultRepoMemoryMaxFileSizeconstant. - Replaced repo-memory default max-file-size values with 102400 bytes.
- Updated schema descriptions and one default-value assertion.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/repo_memory.go |
Defines and applies the new 100KB repo-memory max-file-size default. |
pkg/workflow/repo_memory_test.go |
Updates the boolean-default test expectation to 102400. |
pkg/parser/schemas/main_workflow_schema.json |
Updates schema descriptions for max-file-size default text. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
pkg/workflow/repo_memory.go:342
- The object-style repo-memory default also changed here, but the object test currently supplies an explicit
max-file-size, so this default path is not exercised. Please add coverage for object notation withoutmax-file-sizeto confirm it now uses 102400.
MaxFileSize: defaultRepoMemoryMaxFileSize, // 100KB default
- Files reviewed: 3/3 changed files
- Comments generated: 2
| "minimum": 1, | ||
| "maximum": 104857600, | ||
| "description": "Maximum size per file in bytes (default: 10240 = 10KB)" | ||
| "description": "Maximum size per file in bytes (default: 102400 = 100KB)" |
| if memoryMap, ok := item.(map[string]any); ok { | ||
| entry := RepoMemoryEntry{ | ||
| MaxFileSize: 10240, // 10KB default | ||
| MaxFileSize: defaultRepoMemoryMaxFileSize, // 100KB default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
push_repo_memorywas failing for thesergoworkflow becausesergo-stats.json(11744 bytes) exceeded the defaultMAX_FILE_SIZEof 10240 bytes.Changes
pkg/workflow/repo_memory.go: AddeddefaultRepoMemoryMaxFileSize = 102400constant; replaced all hardcoded10240defaults forMaxFileSizewith the new constantpkg/workflow/repo_memory_test.go: Updated default value assertion to102400pkg/parser/schemas/main_workflow_schema.json: Updatedmax-file-sizefield descriptions to reflect 100KB default