Skip to content

[WIP] Fix failing GitHub Actions job JS Tests (shard 4/4)#32840

Merged
pelikhan merged 7 commits into
mainfrom
copilot/fix-js-tests-shard-4
May 17, 2026
Merged

[WIP] Fix failing GitHub Actions job JS Tests (shard 4/4)#32840
pelikhan merged 7 commits into
mainfrom
copilot/fix-js-tests-shard-4

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 17, 2026

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.

Fix the failing GitHub Actions job "JS Tests (shard 4/4)"
Analyze the Actions logs, identify the root cause of the failure, and implement a fix.
Check run ID: 76410111696
Job URL: https://github.com/github/gh-aw/actions/runs/25995861865/job/76410111696


pr-sous-chef: requested branch update (run: https://github.com/github/gh-aw/actions/runs/25996524238)

Generated by 👨‍🍳 PR Sous Chef ·

…ndler

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI requested a review from pelikhan May 17, 2026 16:20
@pelikhan pelikhan marked this pull request as ready for review May 17, 2026 16:23
Copilot AI review requested due to automatic review settings May 17, 2026 16:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors safe-output large-content handling and applies it to create_issue so oversized issue fields are written to files instead of directly appended.

Changes:

  • Extracted large string detection/offloading into maybeHandleLargeContent.
  • Reused the helper in the default safe-output handler.
  • Added large-content handling to createIssueHandler.
Show a summary per file
File Description
actions/setup/js/safe_outputs_handlers.cjs Refactors large-content handling and applies it to create issue safe outputs.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

actions/setup/js/safe_outputs_handlers.cjs:52

  • The helper stops after offloading the first oversized string field, so any additional >16k-token string fields remain in the NDJSON entry that gets appended. For tools like create_issue with both title and body (or dynamic tools with multiple large string inputs), this can still write an oversized safe-output record and reproduce the failure this handler is meant to avoid. The scan should continue and replace every oversized string field before appending.
    for (const [key, value] of Object.entries(entry)) {
      if (typeof value === "string") {
        const tokens = estimateTokens(value);
        if (tokens > TOKEN_THRESHOLD) {
          largeContent = value;
          largeFieldName = key;
          server.debug(`Field '${key}' has ${tokens} tokens (exceeds ${TOKEN_THRESHOLD})`);
          break;
  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment on lines +1033 to +1034
const largeContentResponse = maybeHandleLargeContent(entry);
if (largeContentResponse) return largeContentResponse;
@pelikhan
Copy link
Copy Markdown
Collaborator

@copilot review all comments

Copilot AI and others added 4 commits May 17, 2026 16:33
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 17, 2026

@copilot review all comments

Addressed. I reviewed the thread and applied the requested follow-up so duplicate create_issue entries also offload large content before append, with focused test coverage for that path. Latest commit: 9e558f9.

@github-actions
Copy link
Copy Markdown
Contributor

WIP: tests failing on JS shard 4/4 — please review.
``
@copilot review all comments

Generated by 👨‍🍳 PR Sous Chef ·

@pelikhan pelikhan merged commit 8c2739e into main May 17, 2026
12 checks passed
@pelikhan pelikhan deleted the copilot/fix-js-tests-shard-4 branch May 17, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants