[schema-coverage] feat: Add schema coverage demo for check-for-updates field#32976
Merged
pelikhan merged 1 commit intoMay 18, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new schema demo workflow markdown file to cover the previously-unused top-level frontmatter field check-for-updates for the schema coverage checker.
Changes:
- Add
schema-demos/schema-demo-check-for-updates.mddemonstrating thecheck-for-updatesfrontmatter key. - Document (in-file) what the field does and provide a minimal
nooptask payload.
Show a summary per file
| File | Description |
|---|---|
| schema-demos/schema-demo-check-for-updates.md | Adds a minimal schema demo file exercising the check-for-updates frontmatter field for coverage. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
+7
to
+9
| engine: codex | ||
| check-for-updates: false | ||
| timeout-minutes: 5 |
Closed
Contributor
Author
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /grill-with-docs — this PR adds a new schema demo file and the key question is whether it accurately represents the domain language and typical usage.
Key Observations
- Demo shows the
false(non-default) value: The demo setscheck-for-updates: false, which per the PR description is "not allowed in strict mode". A reader learning from this demo would see the unusual/restricted form rather than the recommendedtruedefault. Consider either demonstratingtrue(the default, recommended value) or adding an inline comment in the markdown explaining thatfalseis intentionally chosen here to show the field exists (and linking to the strict-mode caveat). - Self-referential task prompt: The workflow body instructs the agent to call
noopwith a hardcoded JSON block, which is a reasonable pattern for a coverage-only demo — this is consistent with otherschema-demos/files.
Positive Highlights
- ✅ Minimal and well-scoped — exactly one field demonstrated, no unnecessary complexity
- ✅ Frontmatter is valid and correctly structured
- ✅ Clear comment that this is a coverage-only demo
Verdict
No blocking issues. The one thing worth considering before merge is whether false is the right value to demo (see inline comment).
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · ● 3.2M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schema Coverage Demo
This PR adds a minimal demo workflow that demonstrates usage of the
check-for-updatesfield in the gh-aw frontmatter schema.Why: The schema feature coverage checker found that
check-for-updateswas not used in any existing workflow.What: Adds
schema-demos/schema-demo-check-for-updates.mdwith a valid, minimal demonstration of this field.Field Description
Control whether the compile-agentic version update check runs in the activation job. When true (default), the activation job downloads config.json from the gh-aw repository and verifies the compiled version is not blocked and meets the minimum supported version. Set to false to disable the check (not allowed in strict mode). See: https://github.github.com/gh-aw/reference/frontmatter/#check-for-updates
Validation
schema-demos/schema-demo-check-for-updates.mdnow contains the top-levelcheck-for-updateskey.make build && make fmtcould not complete because this runner has Go 1.24.13 locally, whilego.modrequires Go 1.25.8, and the toolchain download fromproxy.golang.orgis blocked by the environment firewall.make fmtis blocked by the same missing Go 1.25.8 toolchain.Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
proxy.golang.orgSee Network Configuration for more information.