[schema-coverage] feat: Add schema coverage demo for github-app field#32981
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a minimal schema demo workflow to ensure the github-app top-level frontmatter field is exercised for schema feature coverage.
Changes:
- Added a new schema demo markdown workflow showcasing
github-appwithclient-idandprivate-key. - Included a minimal “noop” task payload consistent with existing schema demo patterns.
Show a summary per file
| File | Description |
|---|---|
| schema-demos/schema-demo-github-app.md | Adds a minimal demo workflow demonstrating the top-level github-app schema field for coverage. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /grill-with-docs — appropriate for a documentation/coverage PR introducing a new demo workflow.
Key Themes
The PR is clean and follows the established pattern from existing schema demos (e.g. schema-demo-labels.md). The frontmatter fields client-id and private-key match the github_app schema definition exactly.
One minor terminology nuance: the PR description and the variable name vars.APP_ID might suggest a numeric App ID, but client-id in the schema accepts the GitHub App client ID (the alphanumeric Iv1. string), not the numeric App ID. The example expression itself (${{ vars.APP_ID }}) is fine as a placeholder, but a brief inline comment in the demo body could help readers provision the right value.
Positive Highlights
- ✅ Perfectly consistent with existing
schema-demos/conventions - ✅ Accurate schema field usage —
client-id+private-keymatch thegithub_appdefinition - ✅ Includes the required
noopsafe-output call, preventing spurious workflow failures - ✅ Minimal and purposeful — no unnecessary scaffolding
Verdict
Approving. The single terminology note above is informational and not blocking.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · ● 4.1M
Schema Coverage Demo
This PR adds a minimal demo workflow that demonstrates usage of the
github-appfield in the gh-aw frontmatter schema.Why: The schema feature coverage checker found that
github-appwas not used in any existing workflow.What: Adds
schema-demos/schema-demo-github-app.mdwith a valid, minimal demonstration of this field.Field Description
Top-level GitHub App configuration used as a fallback for all nested github-app token minting operations (on, safe-outputs, checkout, tools.github, dependencies). When a nested section does not define its own github-app, this top-level configuration is used automatically.
Note
The demo uses placeholder expressions for
vars.APP_IDandsecrets.APP_PRIVATE_KEY. A real GitHub App and matching repository variable/secret are required before running this demo.Validation
schema-demos/schema-demo-github-app.mdnow contains the top-levelgithub-appkey.make build && make fmtcould not complete because this runner has Go 1.24.13 locally, whilego.modrequires Go 1.25.8, and the toolchain download fromproxy.golang.orgis blocked by the environment firewall.make fmtis blocked by the same missing Go 1.25.8 toolchain.Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
proxy.golang.orgSee Network Configuration for more information.