Skip to content

[schema-coverage] feat: Add schema coverage demo for github-app field#32981

Merged
pelikhan merged 1 commit into
mainfrom
schema-coverage-github-app-de25e465a4d313ee
May 18, 2026
Merged

[schema-coverage] feat: Add schema coverage demo for github-app field#32981
pelikhan merged 1 commit into
mainfrom
schema-coverage-github-app-de25e465a4d313ee

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Schema Coverage Demo

This PR adds a minimal demo workflow that demonstrates usage of the github-app field in the gh-aw frontmatter schema.

Why: The schema feature coverage checker found that github-app was not used in any existing workflow.

What: Adds schema-demos/schema-demo-github-app.md with a valid, minimal demonstration of this field.

Field Description

Top-level GitHub App configuration used as a fallback for all nested github-app token minting operations (on, safe-outputs, checkout, tools.github, dependencies). When a nested section does not define its own github-app, this top-level configuration is used automatically.

Note

The demo uses placeholder expressions for vars.APP_ID and secrets.APP_PRIVATE_KEY. A real GitHub App and matching repository variable/secret are required before running this demo.

Validation

  • Coverage grep confirms schema-demos/schema-demo-github-app.md now contains the top-level github-app key.
  • make build && make fmt could not complete because this runner has Go 1.24.13 locally, while go.mod requires Go 1.25.8, and the toolchain download from proxy.golang.org is blocked by the environment firewall.
  • make fmt is blocked by the same missing Go 1.25.8 toolchain.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • proxy.golang.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "proxy.golang.org"

See Network Configuration for more information.

Generated by 📊 Schema Feature Coverage Checker ·

  • expires on May 25, 2026, 7:55 AM UTC

@pelikhan pelikhan marked this pull request as ready for review May 18, 2026 12:47
Copilot AI review requested due to automatic review settings May 18, 2026 12:47
@pelikhan pelikhan merged commit 054a593 into main May 18, 2026
4 checks passed
@pelikhan pelikhan deleted the schema-coverage-github-app-de25e465a4d313ee branch May 18, 2026 12:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a minimal schema demo workflow to ensure the github-app top-level frontmatter field is exercised for schema feature coverage.

Changes:

  • Added a new schema demo markdown workflow showcasing github-app with client-id and private-key.
  • Included a minimal “noop” task payload consistent with existing schema demo patterns.
Show a summary per file
File Description
schema-demos/schema-demo-github-app.md Adds a minimal demo workflow demonstrating the top-level github-app schema field for coverage.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@github-actions github-actions Bot mentioned this pull request May 18, 2026
Copy link
Copy Markdown
Contributor Author

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skills-Based Review 🧠

Applied /grill-with-docs — appropriate for a documentation/coverage PR introducing a new demo workflow.

Key Themes

The PR is clean and follows the established pattern from existing schema demos (e.g. schema-demo-labels.md). The frontmatter fields client-id and private-key match the github_app schema definition exactly.

One minor terminology nuance: the PR description and the variable name vars.APP_ID might suggest a numeric App ID, but client-id in the schema accepts the GitHub App client ID (the alphanumeric Iv1. string), not the numeric App ID. The example expression itself (${{ vars.APP_ID }}) is fine as a placeholder, but a brief inline comment in the demo body could help readers provision the right value.

Positive Highlights

  • ✅ Perfectly consistent with existing schema-demos/ conventions
  • ✅ Accurate schema field usage — client-id + private-key match the github_app definition
  • ✅ Includes the required noop safe-output call, preventing spurious workflow failures
  • ✅ Minimal and purposeful — no unnecessary scaffolding

Verdict

Approving. The single terminology note above is informational and not blocking.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · ● 4.1M

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants