[schema-coverage] feat: Add schema coverage demo for models field#32984
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a minimal schema coverage demo for the top-level models frontmatter field.
Changes:
- Adds a new
schema-demos/schema-demo-models.mdworkflow demo. - Defines a valid
modelsalias with a fallback list. - Documents that the demo is coverage-only and should call
noop.
Show a summary per file
| File | Description |
|---|---|
schema-demos/schema-demo-models.md |
Adds the schema coverage demo for the models field. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /grill-with-docs — this is a documentation/coverage PR introducing a new workflow file.
Assessment
The new schema-demo-models.md is consistent with the established pattern used by schema-demo-labels.md and schema-demo-metadata.md: declare the field in frontmatter, provide a brief explanation, and call noop.
One Observation
The models field is semantically richer than labels — it defines named aliases for use in model resolution. The demo declares the demo alias but never references it (e.g. via a model: demo directive elsewhere in the workflow). For a purely coverage-driven demo this is fine, but a future iteration could show the alias being consumed to make the demo more instructive.
Positive Highlights
- ✅ Minimal permissions (
contents: read) — correctly scoped - ✅ Matches the established schema-demo file structure exactly
- ✅ Short
timeout-minutes: 5appropriate for a noop workflow - ✅ Clear inline explanation of what the field does
Verdict
Approving — the file achieves its stated goal (schema coverage for models) and follows the project's existing conventions.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · ● 2.7M
Schema Coverage Demo
This PR adds a minimal demo workflow that demonstrates usage of the
modelsfield in the gh-aw frontmatter schema.Why: The schema feature coverage checker found that
modelswas not used in any existing workflow.What: Adds
schema-demos/schema-demo-models.mdwith a valid, minimal demonstration of this field.Field Description
Named model alias definitions with ordered fallback lists, resolved recursively by AWF. Each key is an alias name (use empty string "" for the default policy). Each value is an ordered list of vendor/modelid glob patterns or other alias names to try in sequence. Entries defined here are merged on top of the builtin aliases; the main workflow file always wins over imported aliases. Builtin aliases include: sonnet, haiku, opus, gpt-5, gpt-5-mini, gpt-5-codex, gemini-flash, gemini-pro, small, mini, large, auto.
Validation
schema-demos/schema-demo-models.mdnow contains the top-levelmodelskey.make build && make fmtcould not complete because this runner has Go 1.24.13 locally, whilego.modrequires Go 1.25.8, and the toolchain download fromproxy.golang.orgis blocked by the environment firewall.make fmtis blocked by the same missing Go 1.25.8 toolchain.Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
proxy.golang.orgSee Network Configuration for more information.