Skip to content

[schema-coverage] feat: Add schema coverage demo for models field#32984

Merged
pelikhan merged 1 commit into
mainfrom
schema-coverage-models-e1cd5762babe0955
May 18, 2026
Merged

[schema-coverage] feat: Add schema coverage demo for models field#32984
pelikhan merged 1 commit into
mainfrom
schema-coverage-models-e1cd5762babe0955

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Schema Coverage Demo

This PR adds a minimal demo workflow that demonstrates usage of the models field in the gh-aw frontmatter schema.

Why: The schema feature coverage checker found that models was not used in any existing workflow.

What: Adds schema-demos/schema-demo-models.md with a valid, minimal demonstration of this field.

Field Description

Named model alias definitions with ordered fallback lists, resolved recursively by AWF. Each key is an alias name (use empty string "" for the default policy). Each value is an ordered list of vendor/modelid glob patterns or other alias names to try in sequence. Entries defined here are merged on top of the builtin aliases; the main workflow file always wins over imported aliases. Builtin aliases include: sonnet, haiku, opus, gpt-5, gpt-5-mini, gpt-5-codex, gemini-flash, gemini-pro, small, mini, large, auto.

Validation

  • Coverage grep confirms schema-demos/schema-demo-models.md now contains the top-level models key.
  • make build && make fmt could not complete because this runner has Go 1.24.13 locally, while go.mod requires Go 1.25.8, and the toolchain download from proxy.golang.org is blocked by the environment firewall.
  • make fmt is blocked by the same missing Go 1.25.8 toolchain.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • proxy.golang.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "proxy.golang.org"

See Network Configuration for more information.

Generated by 📊 Schema Feature Coverage Checker ·

  • expires on May 25, 2026, 7:56 AM UTC

@pelikhan pelikhan marked this pull request as ready for review May 18, 2026 12:45
Copilot AI review requested due to automatic review settings May 18, 2026 12:45
@pelikhan pelikhan merged commit acf9f48 into main May 18, 2026
4 checks passed
@pelikhan pelikhan deleted the schema-coverage-models-e1cd5762babe0955 branch May 18, 2026 12:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a minimal schema coverage demo for the top-level models frontmatter field.

Changes:

  • Adds a new schema-demos/schema-demo-models.md workflow demo.
  • Defines a valid models alias with a fallback list.
  • Documents that the demo is coverage-only and should call noop.
Show a summary per file
File Description
schema-demos/schema-demo-models.md Adds the schema coverage demo for the models field.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@github-actions github-actions Bot mentioned this pull request May 18, 2026
Copy link
Copy Markdown
Contributor Author

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skills-Based Review 🧠

Applied /grill-with-docs — this is a documentation/coverage PR introducing a new workflow file.

Assessment

The new schema-demo-models.md is consistent with the established pattern used by schema-demo-labels.md and schema-demo-metadata.md: declare the field in frontmatter, provide a brief explanation, and call noop.

One Observation

The models field is semantically richer than labels — it defines named aliases for use in model resolution. The demo declares the demo alias but never references it (e.g. via a model: demo directive elsewhere in the workflow). For a purely coverage-driven demo this is fine, but a future iteration could show the alias being consumed to make the demo more instructive.

Positive Highlights

  • ✅ Minimal permissions (contents: read) — correctly scoped
  • ✅ Matches the established schema-demo file structure exactly
  • ✅ Short timeout-minutes: 5 appropriate for a noop workflow
  • ✅ Clear inline explanation of what the field does

Verdict

Approving — the file achieves its stated goal (schema coverage for models) and follows the project's existing conventions.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · ● 2.7M

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants