Skip to content

[schema-coverage] feat: Add schema coverage demo for pre-steps field#32985

Merged
pelikhan merged 1 commit into
mainfrom
schema-coverage-pre-steps-16d3e8e6e02b3b1b
May 18, 2026
Merged

[schema-coverage] feat: Add schema coverage demo for pre-steps field#32985
pelikhan merged 1 commit into
mainfrom
schema-coverage-pre-steps-16d3e8e6e02b3b1b

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Schema Coverage Demo

This PR adds a minimal demo workflow that demonstrates usage of the pre-steps field in the gh-aw frontmatter schema.

Why: The schema feature coverage checker found that pre-steps was not used in any existing workflow.

What: Adds schema-demos/schema-demo-pre-steps.md with a valid, minimal demonstration of this field.

Field Description

Custom workflow steps to run at the very beginning of the agent job, before checkout and any other built-in steps. Use pre-steps to mint short-lived tokens or perform any setup that must happen before the repository is checked out. Step outputs are available via ${{ steps.(id).outputs.(name) }} and can be referenced in checkout.token to avoid masked-value cross-job-boundary issues.

Validation

  • Coverage grep confirms schema-demos/schema-demo-pre-steps.md now contains the top-level pre-steps key.
  • make build && make fmt could not complete because this runner has Go 1.24.13 locally, while go.mod requires Go 1.25.8, and the toolchain download from proxy.golang.org is blocked by the environment firewall.
  • make fmt is blocked by the same missing Go 1.25.8 toolchain.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • proxy.golang.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "proxy.golang.org"

See Network Configuration for more information.

Generated by 📊 Schema Feature Coverage Checker ·

  • expires on May 25, 2026, 7:56 AM UTC

@pelikhan pelikhan marked this pull request as ready for review May 18, 2026 12:45
Copilot AI review requested due to automatic review settings May 18, 2026 12:45
@pelikhan pelikhan merged commit d8633cf into main May 18, 2026
5 checks passed
@pelikhan pelikhan deleted the schema-coverage-pre-steps-16d3e8e6e02b3b1b branch May 18, 2026 12:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a minimal schema coverage demo workflow for the pre-steps frontmatter field to bring schema feature coverage to 100%.

Changes:

  • New demo workflow file under schema-demos/ following the established sibling-file pattern (matches schema-demo-labels.md and schema-demo-metadata.md).
  • Frontmatter exercises the top-level pre-steps key with a single named echo step.
Show a summary per file
File Description
schema-demos/schema-demo-pre-steps.md New minimal demo workflow exercising the pre-steps frontmatter field for schema coverage.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@github-actions github-actions Bot mentioned this pull request May 18, 2026
Copy link
Copy Markdown
Contributor Author

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skills-Based Review 🧠

Applied /grill-with-docs — this PR introduces a new schema demo file, so I checked vocabulary consistency and structural alignment with existing demos.

Key Themes

  • Consistent pattern: The new schema-demo-pre-steps.md follows the exact same structure as schema-demo-labels.md and schema-demo-metadata.md.
  • Correct vocabulary: The pre-steps field name, description, and inline comments match the project's domain language as defined in the schema and AGENTS.md.
  • Minimal and appropriate: The demo uses workflow_dispatch, engine: codex, permissions: contents: read, and a single step — all sensible defaults for a coverage-only workflow.

Positive Highlights

  • ✅ Auto-generated PR with a consistent template — easy to review and maintain
  • ✅ PR description accurately explains what pre-steps does and why the demo exists
  • ✅ The noop safe-output call is correctly included in the task body

Verdict

Approving. The change is purely additive, structurally correct, and aligns with established schema-demo conventions.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · ● 4M

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants