[schema-coverage] feat: Add schema coverage demo for pre-steps field#32985
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a minimal schema coverage demo workflow for the pre-steps frontmatter field to bring schema feature coverage to 100%.
Changes:
- New demo workflow file under
schema-demos/following the established sibling-file pattern (matchesschema-demo-labels.mdandschema-demo-metadata.md). - Frontmatter exercises the top-level
pre-stepskey with a single named echo step.
Show a summary per file
| File | Description |
|---|---|
| schema-demos/schema-demo-pre-steps.md | New minimal demo workflow exercising the pre-steps frontmatter field for schema coverage. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
Closed
Contributor
Author
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /grill-with-docs — this PR introduces a new schema demo file, so I checked vocabulary consistency and structural alignment with existing demos.
Key Themes
- Consistent pattern: The new
schema-demo-pre-steps.mdfollows the exact same structure asschema-demo-labels.mdandschema-demo-metadata.md. - Correct vocabulary: The
pre-stepsfield name, description, and inline comments match the project's domain language as defined in the schema and AGENTS.md. - Minimal and appropriate: The demo uses
workflow_dispatch,engine: codex,permissions: contents: read, and a single step — all sensible defaults for a coverage-only workflow.
Positive Highlights
- ✅ Auto-generated PR with a consistent template — easy to review and maintain
- ✅ PR description accurately explains what
pre-stepsdoes and why the demo exists - ✅ The
noopsafe-output call is correctly included in the task body
Verdict
Approving. The change is purely additive, structurally correct, and aligns with established schema-demo conventions.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · ● 4M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schema Coverage Demo
This PR adds a minimal demo workflow that demonstrates usage of the
pre-stepsfield in the gh-aw frontmatter schema.Why: The schema feature coverage checker found that
pre-stepswas not used in any existing workflow.What: Adds
schema-demos/schema-demo-pre-steps.mdwith a valid, minimal demonstration of this field.Field Description
Custom workflow steps to run at the very beginning of the agent job, before checkout and any other built-in steps. Use pre-steps to mint short-lived tokens or perform any setup that must happen before the repository is checked out. Step outputs are available via ${{ steps.(id).outputs.(name) }} and can be referenced in checkout.token to avoid masked-value cross-job-boundary issues.
Validation
schema-demos/schema-demo-pre-steps.mdnow contains the top-levelpre-stepskey.make build && make fmtcould not complete because this runner has Go 1.24.13 locally, whilego.modrequires Go 1.25.8, and the toolchain download fromproxy.golang.orgis blocked by the environment firewall.make fmtis blocked by the same missing Go 1.25.8 toolchain.Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
proxy.golang.orgSee Network Configuration for more information.