fix(otlp): derive gh-aw.run.status and status.code from output errors when conclusion env var is absent

[Copilot]

gh-aw.run.status and status.code were hardcoded to "success"/STATUS_CODE_OK on every conclusion span because GH_AW_AGENT_CONCLUSION is empty in the agent job's own post-step — a job cannot observe its own needs.<job>.result. The result: every span in Tempo reported success even on genuinely failed runs, making failure-based alerting and dashboards useless.

Changes

• send_otlp_span.cjs — after reading agent_output.json, if rawRunStatus is empty (both GH_AW_AGENT_CONCLUSION and workflowRunConclusion absent) and outputErrors.length > 0, fall back to observable evidence:

  // Before: runStatus always "success" when env var is absent
  let runStatus = "success";
  const rawRunStatus = agentConclusion || workflowRunConclusion;
  // …only failure when rawRunStatus is explicitly "failure"/"timed_out"
  
  // After: fallback to output errors when no explicit conclusion signal
  if (!rawRunStatus && outputErrors.length > 0) {
    runStatus = "failure";
    statusCode = 2; // STATUS_CODE_ERROR
    statusMessage = `errors detected: ${errorMessages[0]}`.slice(0, 256);
  }

  statusCode changed from const to let to allow the late update.

• send_otlp_span.test.cjs — four new tests in a "run.status fallback from observable error signals" block: fallback fires correctly; statusMessage uses first error; explicit GH_AW_AGENT_CONCLUSION=success is not overridden; no-error path remains success/OK.

[Copilot]

Pull request overview

Fixes a bug where conclusion spans always reported gh-aw.run.status=success and STATUS_CODE_OK even on failed runs, because GH_AW_AGENT_CONCLUSION is empty in the agent job's own post-step (a job can't read its own needs.<job>.result). When no explicit conclusion signal is available, the code now falls back to observable evidence in agent_output.json errors.

Changes:

• In sendJobConclusionSpan, when both GH_AW_AGENT_CONCLUSION and workflowRunConclusion are absent but outputErrors.length > 0, set runStatus="failure", statusCode=2, and a truncated statusMessage derived from the first error.
• Promote statusCode from const to let so the fallback branch can update it.
• Add four unit tests covering: fallback firing, first-error selection for statusMessage, no override when GH_AW_AGENT_CONCLUSION=success, and no-error path staying success/OK.

Show a summary per file

File	Description
actions/setup/js/send_otlp_span.cjs	Adds error-based fallback for runStatus/statusCode/statusMessage when no conclusion env var is present.
actions/setup/js/send_otlp_span.test.cjs	New test block covering the fallback behavior and its boundaries.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 0