Skip to content

Split shared OTLP backend import into Sentry, Grafana, and Datadog components#33202

Merged
mnkiefer merged 4 commits into
mainfrom
copilot/split-otlp-backends-file
May 19, 2026
Merged

Split shared OTLP backend import into Sentry, Grafana, and Datadog components#33202
mnkiefer merged 4 commits into
mainfrom
copilot/split-otlp-backends-file

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 19, 2026

This change decomposes the combined OTLP backend shared import into backend-specific shared workflow components. The smoke OTEL workflow now composes Sentry, Grafana, and Datadog explicitly instead of pulling a single bundled import.

  • What changed

    • Added dedicated shared imports:
      • .github/workflows/shared/sentry.md
      • .github/workflows/shared/grafana.md
      • .github/workflows/shared/datadog.md
    • Removed the combined .github/workflows/shared/otlp-backends.md
    • Updated smoke-otel-backends.md to import the three backend-specific files directly
    • Regenerated smoke-otel-backends.lock.yml to reflect the new import graph
  • Why this shape

    • Makes backend configuration reusable independently
    • Avoids coupling Sentry, Grafana, and Datadog when a workflow only needs a subset
    • Keeps secrets, network rules, and OTLP endpoint config scoped per backend
  • Import change

    imports:
      - shared/sentry.md
      - shared/grafana.md
      - shared/datadog.md

Copilot AI and others added 3 commits May 19, 2026 04:06
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
@mnkiefer mnkiefer marked this pull request as ready for review May 19, 2026 04:16
Copilot AI review requested due to automatic review settings May 19, 2026 04:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR splits the shared OTLP backend configuration into backend-specific workflow imports and updates the smoke OTEL workflow to compose them directly.

Changes:

  • Replaces the bundled OTLP backend import with separate Sentry, Grafana, and Datadog imports.
  • Adds standalone shared OTLP configuration files for Sentry and Grafana, and narrows Datadog to Datadog-only settings.
  • Regenerates the smoke OTEL lock file for the new import graph.
Show a summary per file
File Description
.github/workflows/smoke-otel-backends.md Imports backend-specific OTLP shared components directly.
.github/workflows/smoke-otel-backends.lock.yml Regenerated compiled workflow for the updated imports.
.github/workflows/shared/sentry.md Adds reusable Sentry OTLP endpoint, headers, and network allowlist.
.github/workflows/shared/grafana.md Adds reusable Grafana OTLP endpoint, headers, and network allowlist.
.github/workflows/shared/datadog.md Narrows shared Datadog config to only Datadog OTLP settings.
pkg/workflow/expression_extraction_test.go Applies formatting cleanup to an existing test case.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 5/6 changed files
  • Comments generated: 1

Comment thread .github/workflows/smoke-otel-backends.lock.yml Outdated
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot AI requested a review from mnkiefer May 19, 2026 04:51
@mnkiefer mnkiefer merged commit 1005518 into main May 19, 2026
@mnkiefer mnkiefer deleted the copilot/split-otlp-backends-file branch May 19, 2026 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants