Add panic recovery to mcp inspect background goroutines

[Copilot]

pkg/cli/mcp_inspect_inspector.go had two production goroutines that did not follow the codebase’s panic-isolation convention. A panic in either path could bypass graceful background cleanup and make gh aw mcp inspect fail noisily instead of containing the fault.

• What changed

  • Added the standard defer recover() guard to the MCP server monitor goroutine.
  • Added the same guard to the cleanup wait goroutine that gates shutdown completion.

• Why these paths matter

  • The server monitor goroutine waits on background MCP server processes and reports exit errors.
  • The cleanup wait goroutine signals completion of process shutdown; if it ever panics, the parent path falls back to the timeout branch instead of completing cleanly.

• Result

  • All six production go func() sites under pkg/ now follow the same panic-recovery pattern used elsewhere in the CLI.

go func(serverCmd *exec.Cmd, serverName string) {
	defer wg.Done()
	defer func() {
		if r := recover(); r != nil {
			mcpInspectorLog.Printf("Panic in MCP server monitor for %s (recovered): %v", serverName, r)
		}
	}()

	if err := serverCmd.Wait(); err != nil && verbose {
		fmt.Fprintln(os.Stderr, console.FormatWarningMessage(
			fmt.Sprintf("Server %s exited with error: %v", serverName, err),
		))
	}
}(cmd, config.Name)

[Copilot]

Pull request overview

Adds panic recovery to two background goroutines in the mcp inspect command path so that panics are logged rather than crashing the CLI, aligning these sites with the codebase's existing panic-isolation convention.

Changes:

• Add defer recover() to the MCP server monitor goroutine that waits on server processes.
• Add defer recover() to the cleanup wait goroutine that signals shutdown completion.

Show a summary per file

File	Description
pkg/cli/mcp_inspect_inspector.go	Adds panic recovery guards to two background goroutines, logging recovered panics via mcpInspectorLog.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0