No-op: panic-recovery convention already restored in mcp_inspect_inspector goroutines

[Copilot]

The issue reported two goroutines in pkg/cli/mcp_inspect_inspector.go as missing the project’s panic-isolation defer recover() pattern. On inspection, both target goroutines already implement recovery + logging, matching the convention used elsewhere.

• Problem scope

  • MCP server monitor goroutine (serverCmd.Wait() path)
  • Cleanup waiter goroutine (wg.Wait(); close(done) path)

• Current state in code

  • Both goroutines already include a defer recovery block that logs recovered panics.
  • Happy-path behavior remains unchanged; this is a no-op from a runtime behavior perspective.

• Representative implementation

  go func(serverCmd *exec.Cmd, serverName string) {
      defer wg.Done()
      defer func() {
          if r := recover(); r != nil {
              mcpInspectorLog.Printf("Panic in MCP server monitor for %s (recovered): %v", serverName, r)
          }
      }()
      _ = serverCmd.Wait()
  }()
  
  go func() {
      defer func() {
          if r := recover(); r != nil {
              mcpInspectorLog.Printf("Panic in MCP server cleanup wait (recovered): %v", r)
          }
      }()
      wg.Wait()
      close(done)
  }()

[Copilot]

Pull request overview

This PR updates the Datadog MCP configuration inside the smoke-otel-backends locked GitHub Actions workflow by changing which environment variable is used to populate the DD_APPLICATION_KEY HTTP header value.

Changes:

• Switch headers.DD_APPLICATION_KEY from ${DD_APPLICATION_KEY} to ${DD_APP_KEY} in the embedded MCP gateway JSON config.

Show a summary per file

File	Description
.github/workflows/smoke-otel-backends.lock.yml	Adjusts which env var is referenced for the Datadog application key header in the MCP gateway config.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

.github/workflows/smoke-otel-backends.lock.yml:777

• Within the Datadog MCP config, the headers.DD_APPLICATION_KEY value is now sourced from ${DD_APP_KEY} while the rest of the workflow (and the embedded env block below) still uses ${DD_APPLICATION_KEY}. For consistency with the shared Datadog config (.github/workflows/shared/mcp/datadog.md:7) and the mcp-inspector.lock.yml workflow (headers.DD_APPLICATION_KEY uses ${DD_APPLICATION_KEY}), consider reverting this to ${DD_APPLICATION_KEY} (keeping the existing secret fallback logic in the job env).

                "headers": {
                  "DD_API_KEY": "\${DD_API_KEY}",
                  "DD_APPLICATION_KEY": "\${DD_APP_KEY}",
                  "DD_SITE": "\${DD_SITE}"

• Files reviewed: 1/1 changed files
• Comments generated: 1