Skip to content

[WIP] Fix failing GitHub Actions job lint-go#33429

Merged
pelikhan merged 3 commits into
mainfrom
copilot/fix-lint-go-job
May 20, 2026
Merged

[WIP] Fix failing GitHub Actions job lint-go#33429
pelikhan merged 3 commits into
mainfrom
copilot/fix-lint-go-job

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 20, 2026

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.

Fix the failing GitHub Actions job "lint-go"
Analyze the Actions logs, identify the root cause of the failure, and implement a fix.
Check run ID: 76872917535
Job URL: https://github.com/github/gh-aw/actions/runs/26136555318/job/76872917535

Copilot AI and others added 2 commits May 20, 2026 02:16
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI requested a review from pelikhan May 20, 2026 02:20
@pelikhan pelikhan marked this pull request as ready for review May 20, 2026 02:38
Copilot AI review requested due to automatic review settings May 20, 2026 02:38
@pelikhan pelikhan merged commit 46e3366 into main May 20, 2026
2 checks passed
@pelikhan pelikhan deleted the copilot/fix-lint-go-job branch May 20, 2026 02:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses CI failures by removing a now-unnecessary Go test loop-variable copy (to satisfy current Go/lint semantics) and aligning Datadog MCP config header interpolation with the expected DD_APPLICATION_KEY environment variable.

Changes:

  • Remove redundant tt := tt rebinding in a parallel subtest loop to satisfy copyloopvar/Go 1.25+ range semantics.
  • Update Datadog MCP server config templates in workflow lockfiles to use ${DD_APPLICATION_KEY} instead of ${DD_APP_KEY} for the DD_APPLICATION_KEY header.
Show a summary per file
File Description
pkg/cli/fetch_json_naming_test.go Removes redundant loop-variable rebinding that can trigger copyloopvar under the repo’s Go/lint configuration.
.github/workflows/smoke-otel-backends.lock.yml Fixes Datadog header env-var interpolation to use DD_APPLICATION_KEY.
.github/workflows/mcp-inspector.lock.yml Fixes Datadog header env-var interpolation to use DD_APPLICATION_KEY.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 3/3 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants