[log] Add namespace loggers to three workflow files#33453
Merged
Conversation
Adds debug loggers and entry/decision-point logging to: - pkg/workflow/error_recovery.go (workflow:error_recovery) - pkg/workflow/gh_aw_setup_steps.go (workflow:gh_aw_setup_steps) - pkg/workflow/command_dispatch_validation.go (workflow:command_dispatch_validation) These files previously had no logging despite implementing non-trivial logic (error classification, action ref resolution with fallbacks, workflow_dispatch input validation). Logging follows the pkg:filename convention from AGENTS.md and only emits work when the namespace is enabled via the DEBUG environment variable. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description: [log] Add namespace loggers to three workflow files
PR Number: #33453
Repository: github/gh-aw
Type: observability
Breaking: false
Summary
Added structured logging instrumentation to three workflow package files (
command_dispatch_validation.go,error_recovery.go,gh_aw_setup_steps.go) to improve observability of workflow compilation and validation processes. All changes are purely additive—no logic, APIs, or behavior modified.Changes by File
pkg/workflow/command_dispatch_validation.goworkflow:command_dispatch_validationand logging statements to trace workflow_dispatch input validation decisionscommandDispatchValidationLog = logger.New("workflow:command_dispatch_validation")pkg/workflow/error_recovery.goworkflow:error_recoveryand logging throughout the error recovery pipelineerrorRecoveryLog = logger.New("workflow:error_recovery")pkg/workflow/gh_aw_setup_steps.goworkflow:gh_aw_setup_stepsand logging for setup step generation logicghAwSetupLog = logger.New("workflow:gh_aw_setup_steps")Impact Assessment
workflow:*) enable targeted log filteringTesting Considerations
Dependencies
github.com/github/gh-aw/pkg/loggerpackageRollout Risk
Low — Changes are additive and non-breaking. Logging infrastructure already exists in codebase.
Commit:
eccb345cb— "Add namespace loggers to three workflow files"