[WIP] Fix failing GitHub Actions job JS Tests (shard 2/4)#33455
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates expectations and workflow configuration to address recent MCP validation behavior and Datadog header env var naming.
Changes:
- Adjust HTTP MCP integration test to match the current “empty arguments are not allowed” error behavior for
tools/call. - Update Datadog MCP server header substitution in workflow lock files to use
DD_APPLICATION_KEY.
Show a summary per file
| File | Description |
|---|---|
| actions/setup/js/mcp_scripts_mcp_server_http.test.cjs | Updates assertion for the tools/call empty-arguments error message. |
| .github/workflows/smoke-otel-backends.lock.yml | Fixes Datadog header env placeholder to use DD_APPLICATION_KEY. |
| .github/workflows/mcp-inspector.lock.yml | Fixes Datadog header env placeholder to use DD_APPLICATION_KEY. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 3
Comment on lines
144
to
+147
| it("should handle missing required arguments", async () => { | ||
| const headers = sessionId ? { "Mcp-Session-Id": sessionId } : {}, | ||
| response = await makeRequest({ jsonrpc: "2.0", id: 4, method: "tools/call", params: { name: "echo_tool", arguments: {} } }, headers); | ||
| (expect(response.status).toBe(200), expect(response.data.error).toBeDefined(), expect(response.data.error.message).toContain("missing")); | ||
| (expect(response.status).toBe(200), expect(response.data.error).toBeDefined(), expect(response.data.error.message).toContain("not allowed")); |
Comment on lines
773
to
777
| "url": "https://mcp.datadoghq.com/api/unstable/mcp-server/mcp?toolsets=core", | ||
| "headers": { | ||
| "DD_API_KEY": "\${DD_API_KEY}", | ||
| "DD_APPLICATION_KEY": "\${DD_APP_KEY}", | ||
| "DD_APPLICATION_KEY": "\${DD_APPLICATION_KEY}", | ||
| "DD_SITE": "\${DD_SITE}" |
Comment on lines
1000
to
1004
| "url": "https://mcp.datadoghq.com/api/unstable/mcp-server/mcp?toolsets=core", | ||
| "headers": { | ||
| "DD_API_KEY": "\${DD_API_KEY}", | ||
| "DD_APPLICATION_KEY": "\${DD_APP_KEY}", | ||
| "DD_APPLICATION_KEY": "\${DD_APPLICATION_KEY}", | ||
| "DD_SITE": "\${DD_SITE}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.