-
Notifications
You must be signed in to change notification settings - Fork 391
Improve Daily Reliability Review readability with progressive disclosure #33523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
920cce3
e1954b4
3b053af
8209e99
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -102,6 +102,8 @@ Title: | |
|
|
||
| Body structure: | ||
|
|
||
| Use progressive disclosure. Keep `Executive Summary`, `Top Reliability Findings`, and `Recommendations` always visible. Put verbose evidence and supporting detail inside `<details><summary>...</summary>` blocks. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [/grill-with-docs] The phrase "progressive disclosure" is a UX pattern name, but the workflow prompt uses domain-specific terminology elsewhere ("reliability engineer", "observability telemetry", "trace continuity"). Consider whether this instruction would be clearer using the existing vocabulary: Use collapsible sections to keep the report scannable. Keep `Executive Summary`, `Top Reliability Findings`, and `Recommendations` always visible. Put verbose evidence and supporting detail inside `<details><summary>...</summary>` blocks.This avoids introducing a new concept ("progressive disclosure") when the concrete instruction ("collapsible sections") is already clear and consistent with the |
||
|
|
||
| ### Executive Summary | ||
| - Overall health for the last 24 hours. | ||
|
|
||
|
|
@@ -111,14 +113,24 @@ Body structure: | |
| | ... | ... | ... | ... | ... | | ||
|
|
||
| ### Representative Traces | ||
| <details> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [/grill-with-docs] The Consider adding conditional guidance for when to collapse sections: <details>
<summary>View representative traces</summary>
- Include one trace or issue link for each major problem class when available.
- Collapse this section if there are more than 3 traces to keep the issue body scannable.
</details>This helps the AI agent decide whether to use the collapse feature based on content volume, not just structure. |
||
| <summary>View representative traces</summary> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [/grill-with-docs] The summary text "View representative traces" is clear, but consider making it even more actionable by including a count hint when possible: <summary>View representative traces (one per problem class)</summary>This reinforces the instruction within the collapsed section and helps the AI agent understand the expected scope without expanding the details block. Other daily workflows use this pattern (e.g., |
||
|
|
||
| - Include one trace or issue link for each major problem class when available. | ||
|
|
||
| </details> | ||
|
|
||
| ### Recommendations | ||
| - 2-4 concrete actions with the smallest useful fixes first. | ||
|
|
||
| ### Notes | ||
| <details> | ||
| <summary>View notes</summary> | ||
|
|
||
| - Call out missing telemetry, ambiguous fields, or inconclusive results. | ||
|
|
||
| </details> | ||
|
|
||
| ## Guardrails | ||
|
|
||
| - If no reliability issues are found, call `noop` with a concise summary of what was checked. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/grill-with-docs] The progressive disclosure guidance says to keep certain sections "always visible" and wrap "verbose evidence and supporting detail" in
<details>blocks.Consider being more explicit about which sections should never be collapsed to avoid ambiguity:
This makes it clearer that the three named sections are exempt from collapsing, reducing the risk of the AI agent misinterpreting the instruction.