Skip to content

Update Daily OTel Advisor to use shared Sentry/Grafana OTEL MCP imports#33570

Merged
mnkiefer merged 2 commits into
mainfrom
copilot/update-daily-otel-instrumentation-advisor
May 20, 2026
Merged

Update Daily OTel Advisor to use shared Sentry/Grafana OTEL MCP imports#33570
mnkiefer merged 2 commits into
mainfrom
copilot/update-daily-otel-instrumentation-advisor

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 20, 2026

This updates Daily OTel Instrumentation Advisor to source telemetry evidence from OTEL backends (Sentry + Grafana) instead of log-oriented checks. The workflow now uses shared MCP imports for both backends so telemetry queries are consistent with other OTEL workflows.

  • Workflow config updates

    • Replaced inline Sentry MCP server configuration with shared imports:
      • shared/mcp/sentry.md
      • shared/mcp/grafana.md
    • Kept existing OTEL/reporting imports and daily audit base intact.

  • Prompt/instruction updates

    • Reworked Step 2 from “Sentry-only” to Sentry + Grafana telemetry analysis.
    • Added explicit cross-backend comparison guidance (attribute presence + trace continuity).
    • Updated evaluation language to require conclusions grounded in live Sentry/Grafana OTEL data.

  • Evidence/reporting contract

    • Updated evidence section to require sampled OTEL span evidence from Sentry and Grafana (or explicit reasoning when one backend is unavailable).
imports:
  - uses: shared/daily-audit-base.md
    with:
      title-prefix: "[otel-advisor] "
      expires: 3d
  - shared/mcp/sentry.md
  - shared/mcp/grafana.md
  - shared/otel-queries.md
  - shared/otlp.md

Copilot AI and others added 2 commits May 20, 2026 15:33
@mnkiefer
Plan workflow update for OTEL backend imports
7233daa 
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
@mnkiefer
Update Daily OTel advisor to use shared Sentry and Grafana MCP imports
7b9aea2 
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
@mnkiefer mnkiefer marked this pull request as ready for review May 20, 2026 15:45
Copilot AI review requested due to automatic review settings May 20, 2026 15:45
@mnkiefer mnkiefer merged commit f101fa6 into main May 20, 2026
32 of 34 checks passed
@mnkiefer mnkiefer deleted the copilot/update-daily-otel-instrumentation-advisor branch May 20, 2026 15:47
Copilot AI reviewed May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Daily OTel Instrumentation Advisor workflow to ground its recommendations in live OTel telemetry evidence from both Sentry and Grafana, and switches the workflow to use the repo’s shared MCP imports for those backends.

Changes:

  • Replaced inline Sentry MCP server configuration with shared imports (shared/mcp/sentry.md, shared/mcp/grafana.md).
  • Updated the prompt instructions to query and compare Sentry + Grafana trace/span evidence.
  • Regenerated the compiled lock workflow to include the new MCP server wiring and related runtime config.
Show a summary per file
File Description
.github/workflows/daily-otel-instrumentation-advisor.md Switches to shared Sentry/Grafana MCP imports and updates Step 2 guidance to require cross-backend OTel evidence.
.github/workflows/daily-otel-instrumentation-advisor.lock.yml Regenerated compiled workflow including Grafana + Sentry MCP server config and updated runtime wiring.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 3

Comment thread .github/workflows/daily-otel-instrumentation-advisor.lock.yml
# gh-aw-metadata: {"schema_version":"v3","frontmatter_hash":"996ce4fda9386040f5919213c347d3ee4fd0f4c974d4941c2f3a08ebb06aeeee","strict":true,"agent_id":"claude"}
# gh-aw-manifest: {"version":1,"secrets":["ANTHROPIC_API_KEY","GH_AW_GITHUB_MCP_SERVER_TOKEN","GH_AW_GITHUB_TOKEN","GH_AW_OTEL_GRAFANA_AUTHORIZATION","GH_AW_OTEL_GRAFANA_ENDPOINT","GH_AW_OTEL_SENTRY_AUTHORIZATION","GH_AW_OTEL_SENTRY_ENDPOINT","GITHUB_TOKEN","SENTRY_API_KEY"],"actions":[{"repo":"actions/checkout","sha":"de0fac2e4500dabe0009e67214ff5f5447ce83dd","version":"v6.0.2"},{"repo":"actions/download-artifact","sha":"3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c","version":"v8.0.1"},{"repo":"actions/github-script","sha":"3a2844b7e9c422d3c10d287c895573f7108da1b3","version":"v9.0.0"},{"repo":"actions/setup-node","sha":"48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e","version":"v6.4.0"},{"repo":"actions/upload-artifact","sha":"043fb46d1a93c77aae656e7c1c64a875d1fc6a0a","version":"v7.0.1"}],"containers":[{"image":"ghcr.io/github/gh-aw-firewall/agent:0.25.49"},{"image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.25.49"},{"image":"ghcr.io/github/gh-aw-firewall/cli-proxy:0.25.49"},{"image":"ghcr.io/github/gh-aw-firewall/squid:0.25.49"},{"image":"ghcr.io/github/gh-aw-mcpg:v0.3.9","digest":"sha256:64828b42a4482f58fab16509d7f8f495a6d97c972a98a68aff20543531ac0388","pinned_image":"ghcr.io/github/gh-aw-mcpg:v0.3.9@sha256:64828b42a4482f58fab16509d7f8f495a6d97c972a98a68aff20543531ac0388"},{"image":"ghcr.io/github/github-mcp-server:v1.0.4"},{"image":"node:lts-alpine","digest":"sha256:d1b3b4da11eefd5941e7f0b9cf17783fc99d9c6fc34884a665f40a06dbdfc94f","pinned_image":"node:lts-alpine@sha256:d1b3b4da11eefd5941e7f0b9cf17783fc99d9c6fc34884a665f40a06dbdfc94f"}]}
# gh-aw-metadata: {"schema_version":"v3","frontmatter_hash":"38d09ecf08218793a9762d77765810a3d91a33401282c0b6475231a13fabc8db","compiler_version":"v0.74.4","strict":true,"agent_id":"claude"}
# gh-aw-manifest: {"version":1,"secrets":["ANTHROPIC_API_KEY","GH_AW_GITHUB_MCP_SERVER_TOKEN","GH_AW_GITHUB_TOKEN","GH_AW_OTEL_GRAFANA_AUTHORIZATION","GH_AW_OTEL_GRAFANA_ENDPOINT","GH_AW_OTEL_SENTRY_AUTHORIZATION","GH_AW_OTEL_SENTRY_ENDPOINT","GITHUB_TOKEN","GRAFANA_SERVICE_ACCOUNT_TOKEN","GRAFANA_URL","SENTRY_ACCESS_TOKEN","SENTRY_OPENAI_API_KEY"],"actions":[{"repo":"actions/checkout","sha":"de0fac2e4500dabe0009e67214ff5f5447ce83dd","version":"v6.0.2"},{"repo":"actions/download-artifact","sha":"3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c","version":"v8.0.1"},{"repo":"actions/github-script","sha":"3a2844b7e9c422d3c10d287c895573f7108da1b3","version":"v9.0.0"},{"repo":"actions/github-script","sha":"v9","version":"v9"},{"repo":"actions/setup-node","sha":"48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e","version":"v6.4.0"},{"repo":"actions/upload-artifact","sha":"043fb46d1a93c77aae656e7c1c64a875d1fc6a0a","version":"v7.0.1"},{"repo":"github/gh-aw-actions/setup","sha":"v0.74.4","version":"v0.74.4"}],"resolution_failures":[{"repo":"actions/github-script","ref":"v9","error_type":"dynamic_resolution_failed"}],"containers":[{"image":"ghcr.io/github/gh-aw-firewall/agent:0.25.46"},{"image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.25.46"},{"image":"ghcr.io/github/gh-aw-firewall/cli-proxy:0.25.46"},{"image":"ghcr.io/github/gh-aw-firewall/squid:0.25.46"},{"image":"ghcr.io/github/gh-aw-mcpg:v0.3.9","digest":"sha256:64828b42a4482f58fab16509d7f8f495a6d97c972a98a68aff20543531ac0388","pinned_image":"ghcr.io/github/gh-aw-mcpg:v0.3.9@sha256:64828b42a4482f58fab16509d7f8f495a6d97c972a98a68aff20543531ac0388"},{"image":"ghcr.io/github/github-mcp-server:v1.0.4"},{"image":"grafana/mcp-grafana","digest":"sha256:60a4e3a417a69eeb864a72052c53b4aa4466ff3577d6ef9bacc671f4b77d7090","pinned_image":"grafana/mcp-grafana@sha256:60a4e3a417a69eeb864a72052c53b4aa4466ff3577d6ef9bacc671f4b77d7090"},{"image":"node:lts-alpine","digest":"sha256:d1b3b4da11eefd5941e7f0b9cf17783fc99d9c6fc34884a665f40a06dbdfc94f","pinned_image":"node:lts-alpine@sha256:d1b3b4da11eefd5941e7f0b9cf17783fc99d9c6fc34884a665f40a06dbdfc94f"}]}
Comment thread .github/workflows/daily-otel-instrumentation-advisor.lock.yml
Comment on lines 446 to 450
- name: Setup Node.js
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: '24'
package-manager-cache: false
Comment thread .github/workflows/daily-otel-instrumentation-advisor.lock.yml
Comment on lines 451 to 453
- name: Install AWF binary
run: bash "${RUNNER_TEMP}/gh-aw/actions/install_awf_binary.sh" v0.25.49
run: bash "${RUNNER_TEMP}/gh-aw/actions/install_awf_binary.sh" v0.25.46
- name: Install Claude Code CLI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@mnkiefer mnkiefer mnkiefer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mnkiefer mnkiefer

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mnkiefer