Skip to content

fix: add required_field_removals to toolsMeta JSDoc type#33707

Merged
pelikhan merged 1 commit into
mainfrom
copilot/lint-js
May 21, 2026
Merged

fix: add required_field_removals to toolsMeta JSDoc type#33707
pelikhan merged 1 commit into
mainfrom
copilot/lint-js

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 21, 2026

generate_safe_outputs_tools.cjs accesses toolsMeta.required_field_removals but the property was missing from the JSDoc @type annotation, causing a TS2339 typecheck failure in CI.

Changes

  • actions/setup/js/generate_safe_outputs_tools.cjs: Add required_field_removals?: Record<string, string[]> to the toolsMeta type annotation
-/** @type {{description_suffixes?: Record<string, string>, repo_params?: Record<string, {type: string, description: string}>, dynamic_tools?: Array<unknown>}} */
+/** @type {{description_suffixes?: Record<string, string>, repo_params?: Record<string, {type: string, description: string}>, dynamic_tools?: Array<unknown>, required_field_removals?: Record<string, string[]>}} */

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan pelikhan marked this pull request as ready for review May 21, 2026 05:53
Copilot AI review requested due to automatic review settings May 21, 2026 05:53
@pelikhan pelikhan merged commit fee7917 into main May 21, 2026
@pelikhan pelikhan deleted the copilot/lint-js branch May 21, 2026 05:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the JSDoc @type annotation for toolsMeta so it matches runtime usage in generate_safe_outputs_tools.cjs, unblocking CI typechecking (TS2339) when accessing toolsMeta.required_field_removals.

Changes:

  • Extend the toolsMeta JSDoc type to include required_field_removals?: Record<string, string[]>.
Show a summary per file
File Description
actions/setup/js/generate_safe_outputs_tools.cjs Adds the missing required_field_removals property to the toolsMeta JSDoc type to align with existing access in the script.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants