fix: add required_field_removals to toolsMeta JSDoc type#33707
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
May 21, 2026 05:53
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the JSDoc @type annotation for toolsMeta so it matches runtime usage in generate_safe_outputs_tools.cjs, unblocking CI typechecking (TS2339) when accessing toolsMeta.required_field_removals.
Changes:
- Extend the
toolsMetaJSDoc type to includerequired_field_removals?: Record<string, string[]>.
Show a summary per file
| File | Description |
|---|---|
| actions/setup/js/generate_safe_outputs_tools.cjs | Adds the missing required_field_removals property to the toolsMeta JSDoc type to align with existing access in the script. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate_safe_outputs_tools.cjsaccessestoolsMeta.required_field_removalsbut the property was missing from the JSDoc@typeannotation, causing aTS2339typecheck failure in CI.Changes
actions/setup/js/generate_safe_outputs_tools.cjs: Addrequired_field_removals?: Record<string, string[]>to thetoolsMetatype annotation