Demote strict-mode ecosystem domain guidance from warning to info#33776
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
Update strict-mode ecosystem guidance to informational output
Demote strict-mode ecosystem domain guidance from warning to info
May 21, 2026
Copilot created this pull request from a session on behalf of
pelikhan
May 21, 2026 14:40
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts strict-mode validation output so ecosystem-domain guidance is informational rather than a warning, keeping the recommendation visible while no longer contributing to the compiler warning count.
Changes:
- Switch ecosystem-domain guidance in
validateStrictFirewallfrom warning formatting/counting to info formatting (and remove thestrict mode:prefix). - Update strict firewall tests to stop asserting warning-count increments and add stderr output assertions for the new message shape.
- Update network reference docs to describe the guidance as informational output.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/strict_mode_permissions_validation.go | Emits ecosystem-domain recommendations as informational output and no longer increments warning count. |
| pkg/workflow/strict_mode_llm_gateway_test.go | Updates strict firewall tests to assert info guidance behavior and validate stderr output/message shape. |
| docs/src/content/docs/reference/network.md | Rewords the strict-mode ecosystem guidance section from warnings to informational messaging. |
| .github/workflows/aw-portfolio-yield.lock.yml | Regenerates a lock workflow file (including a cron schedule change). |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (2)
pkg/workflow/strict_mode_llm_gateway_test.go:87
- The inline comment still says these ecosystem domains "will emit warnings" suggesting identifiers, but validateStrictFirewall now prints informational guidance and does not increment warningCount. Please update the comment to avoid confusing future readers/tests.
This issue also appears on line 120 of the same file.
t.Run("copilot engine allows domains from known ecosystems with informational ecosystem guidance in strict mode", func(t *testing.T) {
compiler := NewCompiler()
compiler.strictMode = true
// These domains are from known ecosystems (python, node) and will emit warnings suggesting ecosystem identifiers
networkPerms := &NetworkPermissions{
pkg/workflow/strict_mode_llm_gateway_test.go:126
- This inline comment says the domains "will emit warnings" suggesting ecosystem identifiers, but the updated strict-mode behavior prints informational guidance without affecting warningCount. Please adjust the wording to match the new behavior.
t.Run("codex engine allows domains from known ecosystems with informational ecosystem guidance", func(t *testing.T) {
compiler := NewCompiler()
compiler.strictMode = true
// These domains are from known ecosystems (python, node) and will emit warnings suggesting ecosystem identifiers
networkPerms := &NetworkPermissions{
Allowed: []string{"pypi.org", "registry.npmjs.org"},
- Files reviewed: 4/4 changed files
- Comments generated: 2
Comment on lines
+169
to
175
| ### Informational Messages | ||
|
|
||
| When strict mode encounters an individual ecosystem domain, it emits a warning suggesting the appropriate ecosystem identifier: | ||
| When strict mode encounters an individual ecosystem domain, it emits an informational message suggesting the appropriate ecosystem identifier: | ||
|
|
||
| ````text | ||
| warning: strict mode: recommend using ecosystem identifiers instead of individual domain names for better maintainability: 'pypi.org' → 'python', 'npmjs.org' → 'node' | ||
| recommend using ecosystem identifiers instead of individual domain names for better maintainability: 'pypi.org' → 'python', 'npmjs.org' → 'node' | ||
| ```` |
Comment on lines
66
to
71
| name: "Agentic Workflow Portfolio Yield" | ||
| on: | ||
| schedule: | ||
| - cron: "7 9 * * 1" | ||
| - cron: "40 8 * * 1" | ||
| # Friendly format: weekly on monday around 09:00 (scattered) | ||
| workflow_dispatch: |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strict-mode validation was surfacing ecosystem-domain guidance as a warning, including the
strict mode:prefix and warning count impact. This change keeps the guidance visible while treating it as informational output instead.Behavior
validateStrictFirewallfrom warning formatting to info formattingstrict mode:warning prefix from the emitted messageTests
Docs