refactor(workflow): migrate resolve_test.go to testify assertions

[Copilot]

pkg/workflow/resolve_test.go had zero testify usage — relying entirely on manual if/t.Fatal/t.Errorf patterns — plus duplicated setup boilerplate across six test functions and a buggy custom contains helper that reimplemented strings.Contains.

Changes

• Imports: Add testify/assert and testify/require
• setupWorkflowDir helper: Extracts the repeated temp-dir + MkdirAll + t.Chdir boilerplate into a single helper returning the workflows path
• Assertion migration:
  • t.Fatal(err) → require.NoError(t, err, "...")
  • if err == nil { t.Errorf(...) } → require.Error / assert.Error
  • if result != expected { t.Errorf(...) } → assert.Equal / assert.Contains
  • All assertions include contextual failure messages
• TestResolveWorkflowName_ExistingAgenticWorkflow: Replace os.Chdir + defer os.Chdir with t.Chdir
• helpers_test.go (new): Relocates contains/findSubstring out of resolve_test.go — they're still referenced by step_order_validation_test.go and step_order_validation_bug_detection_test.go, so removing them entirely would break the build

Before / after:

// Before
err = os.MkdirAll(workflowsDir, 0755)
if err != nil {
    t.Fatal(err)
}
// ...
if result != tt.expectedWorkflowName {
    t.Errorf("Expected workflow name %q, got %q", tt.expectedWorkflowName, result)
}

// After
workflowsDir := setupWorkflowDir(t)
// ...
assert.Equal(t, tt.expectedWorkflowName, result,
    "ResolveWorkflowName(%q) should return correct workflow name", tt.workflowInput)

[Copilot]

Pull request overview

Refactors pkg/workflow/resolve_test.go to use testify/assert + testify/require, reducing repetitive boilerplate and standardizing assertion style for workflow resolution tests.

Changes:

• Added setupWorkflowDir helper to centralize temp-dir + workflow-dir setup for multiple tests.
• Migrated manual if/t.Fatal/t.Errorf assertions to testify assertions throughout the file.
• Moved the legacy contains / findSubstring test helpers into a new helpers_test.go to keep other tests compiling.

Show a summary per file

File	Description
pkg/workflow/resolve_test.go	Migrates assertions to testify and extracts shared temp workflow-dir setup.
pkg/workflow/helpers_test.go	Adds a shared (deprecated) contains helper used by other tests in the package.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

pkg/workflow/resolve_test.go:223

• Using t.Chdir(projectRoot) changes the process working directory for the remainder of the test (global state). To keep the test hermetic and avoid cross-test interference, consider instead setting GH_AW_WORKFLOWS_DIR to an absolute path (e.g., filepath.Join(projectRoot, constants.GetWorkflowDir())) and using absolute paths for the os.Stat checks.

	t.Chdir(projectRoot)

• Files reviewed: 2/2 changed files
• Comments generated: 3