Surface experiment metadata fields in picker step summary#34665
Merged
pelikhan merged 4 commits intoMay 25, 2026
Conversation
10 tasks
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…mmary Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix experiment infrastructure: complete frontmatter schema
Surface experiment metadata fields in picker step summary
May 25, 2026
Collaborator
|
@copilot use progressive disclosure, details element and same style of headers as other reports |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes experiment frontmatter metadata (analysis_type, tags, notify) visible at runtime by emitting it into the GitHub Actions step summary produced by pick_experiment.cjs, and adds a focused test to validate the new summary rendering.
Changes:
- Extend
pick_experiment.cjsstep summary with an “Assignment Details” section (per selected experiment) includinganalysis_type,tags,notify, andmin_samples-aware run count formatting. - Add a targeted test case covering the new summary output.
- Regenerate/update multiple workflow
*.lock.ymlfiles (firewall config/model allowlists embedded in workflows).
Show a summary per file
| File | Description |
|---|---|
| actions/setup/js/pick_experiment.cjs | Adds per-assignment metadata rendering to the step summary output. |
| actions/setup/js/pick_experiment.test.cjs | Adds a test asserting the new summary content for analysis_type, tags, notify, and min_samples formatting. |
| .github/workflows/workflow-health-manager.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/workflow-generator.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/video-analyzer.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/test-workflow.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/test-quality-sentinel.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/test-project-url-default.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/test-dispatcher.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/super-linter.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/slide-deck-maintainer.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/security-review.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/security-compliance.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/repo-tree-map.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/refiner.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/q.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/pr-description-caveman.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/poem-bot.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/plan.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/pdf-summary.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/metrics-collector.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/mergefest.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/lint-monster.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/jsweep.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/gpclean.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/dev-hawk.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/craft.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/contribution-check.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/code-simplifier.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/brave.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/archie.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/agentic-token-optimizer.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/agentic-token-audit.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
| .github/workflows/ace-editor.lock.yml | Updates embedded firewall/model allowlist config in the locked workflow. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 116/237 changed files
- Comments generated: 2
Comment on lines
232
to
+236
| const runsForExp = state.runs ? state.runs.filter(r => r.assignments && name in r.assignments) : null; | ||
| const totalCount = runsForExp !== null && runsForExp.length > 0 ? runsForExp.length : Object.values(/** @type {number[]} */ counts).reduce((a, b) => a + b, 0); | ||
| lines.push(`| \`${name}\` | **${selected}** | ${thisCount} / ${totalCount} |`); | ||
|
|
||
| const cfg = configs[name] || {}; |
Comment on lines
+254
to
+256
| detailLines.push("| Field | Value |"); | ||
| detailLines.push("| --- | --- |"); | ||
| detailLines.push(`| Experiment | \`${name}\` |`); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
analysis_type,tags, andnotifywere already compiled from workflow frontmatter but were effectively inert in the JS picker runtime. This change makes those fields operational in runtime reporting by surfacing them in the assignment summary emitted bypick_experiment.cjs.Step summary now includes schema metadata per assignment
pick_experiment.cjsfor each selected experiment.ExperimentAssigned variantAnalysis typeRun count (this variant)(withmin_samplestarget when present)tagsandnotifyare now runtime-visibleTagsrow (formatted list)Notifyrow (discussion/issue targets)Focused coverage for the new behavior
pick_experiment.test.cjsasserting summary rendering for:analysis_typetagsnotifymin_samples-aware run count formatting