Migrate pkg/cli/git_test.go to testify assertions

[Copilot]

pkg/cli/git_test.go had solid coverage but still relied on raw t.Fatal* / t.Error* checks throughout. This updates the file to use the repository’s standard testify assertion style while preserving the existing Git test scenarios and table-driven structure.

• Adopt require for setup and execution prerequisites

  • Replaced setup-time t.Fatalf(...) calls with require.NoError(...) for temp dir setup, repo initialization steps, file creation, and command execution that must succeed for the test to remain valid.

• Adopt assert for behavioral checks

  • Replaced raw t.Error(...) / t.Errorf(...) checks with targeted assert.* calls such as:
    • assert.Equal(...) for branch names, hosts, remote names, and repository slugs
    • assert.Contains(...) for commit log validation
    • assert.Error(...) for expected failure paths
    • assert.True(...) / assert.False(...) / assert.Empty(...) / assert.NotEmpty(...) for status and presence checks

• Split compound status checks into explicit assertions

  • Workflow file status tests now verify IsModified, IsStaged, and HasUnpushedCommits independently, which makes failures more precise and easier to diagnose.

• Keep test behavior unchanged

  • No production code changes.
  • No scenario additions or removals.
  • Existing helper flow and subtest structure remain intact.

Example of the assertion style change:

status, err := checkWorkflowFileStatus(workflowFile)
require.NoError(t, err, "get workflow file status for clean file")
assert.False(t, status.IsModified, "clean file should not be marked modified")
assert.False(t, status.IsStaged, "clean file should not be marked staged")
assert.False(t, status.HasUnpushedCommits, "clean file should not report unpushed commits")

[Copilot]

Pull request overview

This pull request updates pkg/cli/git_test.go to use the repository’s standard testify assertion style (require for prerequisites and assert for behavioral checks) while keeping the existing Git-related test scenarios and structure intact.

Changes:

• Replaced setup-time t.Fatal*/t.Error* checks with require.NoError where test execution cannot proceed on failure.
• Replaced behavioral validations with targeted assert.* calls (e.g., Equal, Contains, Error, Empty, True/False).
• Split compound workflow status checks into explicit assertions for clearer failure output.

Show a summary per file

File	Description
pkg/cli/git_test.go	Migrates Git unit tests to testify (assert/require) for clearer, more consistent assertions without changing test behavior.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0