Set Codex default fallback model to gpt-5.4 and regenerate lockfiles#34804
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
🚀 Smoke Pi MISSION COMPLETE! Pi delivered. 🥧 |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
|
|
🚀 Smoke Gemini MISSION COMPLETE! Gemini has spoken. ✨ Smoke test completed with a build failure. Attempting to report. |
|
💫 TO BE CONTINUED... Smoke Claude failed! Our hero faces unexpected challenges... |
|
🌑 The shadows whisper... Smoke Codex failed to deliver outputs. The oracle requires further meditation... Caution agentic threat detected |
Smoke Test Results
Overall Status: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
Agent Container Tool Check
Result: 12/12 tools available ✅ Overall Status: PASS
|
|
Caution agentic threat detected Smoke test status: FAIL
Warning Firewall blocked 6 domainsThe following domains were blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "accounts.google.com"
- "android.clients.google.com"
- "clients2.google.com"
- "contentautofill.googleapis.com"
- "safebrowsingohttpgateway.googleapis.com"
- "www.google.com"See Network Configuration for more information.
|
|
Caution agentic threat detected Comment MemoryNote This comment is managed by comment memory.It stores persistent context for this thread in the code block at the top of this comment. Warning Firewall blocked 6 domainsThe following domains were blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "accounts.google.com"
- "android.clients.google.com"
- "clients2.google.com"
- "contentautofill.googleapis.com"
- "safebrowsingohttpgateway.googleapis.com"
- "www.google.com"See Network Configuration for more information.
|
|
Smoke Copilot 26425207102: FAIL Warning Firewall blocked 6 domainsThe following domains were blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "accounts.google.com"
- "android.clients.google.com"
- "clients2.google.com"
- "contentautofill.googleapis.com"
- "safebrowsingohttpgateway.googleapis.com"
- "www.google.com"See Network Configuration for more information.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Smoke review completed for PR #34804. Inline comments were added to representative generated lockfile updates.
Warning
Firewall blocked 6 domains
The following domains were blocked by the firewall during workflow execution:
accounts.google.comandroid.clients.google.comclients2.google.comcontentautofill.googleapis.comsafebrowsingohttpgateway.googleapis.comwww.google.com
To allow these domains, add them to the
network.allowedlist in your workflow frontmatter:
network:
allowed:
- defaults
- "accounts.google.com"
- "android.clients.google.com"
- "clients2.google.com"
- "contentautofill.googleapis.com"
- "safebrowsingohttpgateway.googleapis.com"
- "www.google.com"See Network Configuration for more information.
📰 BREAKING: Report filed by Smoke Copilot · gpt55 4.6M
| GH_AW_INFO_ENGINE_ID: "codex" | ||
| GH_AW_INFO_ENGINE_NAME: "Codex" | ||
| GH_AW_INFO_MODEL: ${{ vars.GH_AW_MODEL_AGENT_CODEX || 'gpt-5.3-codex' }} | ||
| GH_AW_INFO_MODEL: ${{ vars.GH_AW_MODEL_AGENT_CODEX || 'gpt-5.4' }} |
There was a problem hiding this comment.
Smoke review: verified this generated lockfile metadata fallback reflects the PR's Codex model change.
| CODEX_HOME: /tmp/gh-aw/mcp-config | ||
| GH_AW_MCP_CONFIG: ${{ runner.temp }}/gh-aw/mcp-config/config.toml | ||
| GH_AW_MODEL_AGENT_CODEX: ${{ vars.GH_AW_MODEL_AGENT_CODEX || 'gpt-5.3-codex' }} | ||
| GH_AW_MODEL_AGENT_CODEX: ${{ vars.GH_AW_MODEL_AGENT_CODEX || 'gpt-5.4' }} |
There was a problem hiding this comment.
Smoke review: this runtime model fallback is consistent with the updated metadata fallback above.
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Smoke Test: Claude — Run 26425207108Core #1–#13: ✅ all green · PR review #14–#16, #18–#19: ✅ · #17 Overall: PARTIAL (all functional tests passed; only design-skipped tests are Warning Firewall blocked 6 domainsThe following domains were blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "accounts.google.com"
- "android.clients.google.com"
- "clients2.google.com"
- "contentautofill.googleapis.com"
- "safebrowsingohttpgateway.googleapis.com"
- "www.google.com"See Network Configuration for more information.
|
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal!
Warning
Firewall blocked 6 domains
The following domains were blocked by the firewall during workflow execution:
accounts.google.comandroid.clients.google.comclients2.google.comcontentautofill.googleapis.comsafebrowsingohttpgateway.googleapis.comwww.google.com
To allow these domains, add them to the
network.allowedlist in your workflow frontmatter:
network:
allowed:
- defaults
- "accounts.google.com"
- "android.clients.google.com"
- "clients2.google.com"
- "contentautofill.googleapis.com"
- "safebrowsingohttpgateway.googleapis.com"
- "www.google.com"See Network Configuration for more information.
💥 [THE END] — Illustrated by Smoke Claude · opus47 7.4M
| // Used as the fallback when no explicit model is configured and the | ||
| // GH_AW_MODEL_AGENT_CODEX / GH_AW_MODEL_DETECTION_CODEX variable is unset. | ||
| CodexDefaultModel = "gpt-5.3-codex" | ||
| CodexDefaultModel = "gpt-5.4" |
There was a problem hiding this comment.
Minor: consider adding a short inline comment explaining the rationale for the gpt-5.4 default (e.g., link to model card / availability) so future bumps have context. (smoke test feedback — Run 26425207108)
| // GH_AW_MODEL_AGENT_CODEX / GH_AW_MODEL_DETECTION_CODEX variable is unset. | ||
| CodexDefaultModel = "gpt-5.3-codex" | ||
| CodexDefaultModel = "gpt-5.4" | ||
|
|
There was a problem hiding this comment.
Nit: when the default model changes, it's worth double-checking that downstream fallback chains and tests reference the same constant rather than a hard-coded string. (smoke test feedback — Run 26425207108)
There was a problem hiding this comment.
Pull request overview
Updates the Codex engine’s default fallback model so workflows that don’t explicitly set a model (and don’t have GH_AW_MODEL_AGENT_CODEX / GH_AW_MODEL_DETECTION_CODEX set) now fall back to gpt-5.4, and regenerates the affected generated workflow lockfiles to keep emitted defaults consistent with the source constant.
Changes:
- Updated
CodexDefaultModelfromgpt-5.3-codextogpt-5.4. - Regenerated impacted
.github/workflows/*.lock.ymlartifacts to reflect the new default model fallback in emitted env defaults / info fields.
Show a summary per file
| File | Description |
|---|---|
| pkg/constants/engine_constants.go | Bumps Codex default fallback model constant to gpt-5.4. |
| .github/workflows/smoke-codex.lock.yml | Regenerated to emit gpt-5.4 as the Codex model fallback. |
| .github/workflows/schema-feature-coverage.lock.yml | Regenerated to emit gpt-5.4 as the Codex model fallback. |
| .github/workflows/necromancer.lock.yml | Regenerated to emit gpt-5.4 as the Codex model fallback. |
| .github/workflows/issue-arborist.lock.yml | Regenerated to emit gpt-5.4 as the Codex model fallback. |
| .github/workflows/grumpy-reviewer.lock.yml | Regenerated to emit gpt-5.4 as the Codex model fallback. |
| .github/workflows/duplicate-code-detector.lock.yml | Regenerated to emit gpt-5.4 as the Codex model fallback. |
| .github/workflows/daily-cache-strategy-analyzer.lock.yml | Regenerated to emit gpt-5.4 as the Codex model fallback. |
| .github/workflows/codex-github-remote-mcp-test.lock.yml | Regenerated to emit gpt-5.4 as the Codex model fallback. |
| .github/workflows/ai-moderator.lock.yml | Regenerated to emit gpt-5.4 as the Codex model fallback. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 10/10 changed files
- Comments generated: 0
Codex workflows were defaulting to
gpt-5.3-codexwhen no explicit model override was provided. This updates the Codex engine default togpt-5.4and recompiles generated lockfiles so runtime fallbacks stay consistent with source constants.Default model constant
CodexDefaultModelinpkg/constants/engine_constants.gofromgpt-5.3-codextogpt-5.4.Generated workflow artifacts
.github/workflows/*.lock.ymlfiles whereGH_AW_MODEL_AGENT_CODEX/GH_AW_MODEL_DETECTION_CODEXdefaults are emitted.✨ PR Review Safe Output Test - Run 26425207108
Warning
Firewall blocked 6 domains
The following domains were blocked by the firewall during workflow execution:
accounts.google.comandroid.clients.google.comclients2.google.comcontentautofill.googleapis.comsafebrowsingohttpgateway.googleapis.comwww.google.comSee Network Configuration for more information.