[log] Add debug logging to 5 workflow files#3481
Merged
pelikhan merged 1 commit intoNov 8, 2025
Merged
Conversation
Enhanced the following files with debug logging statements following the project's logging guidelines: 1. **pkg/workflow/manual_approval.go** (manualApprovalLog) - Added logging for manual approval configuration processing - Logs on: section format detection and extraction results - Logs configuration success or absence 2. **pkg/workflow/copilot_participant_steps.go** (copilotParticipantLog) - Added logging for Copilot participant steps generation - Logs participant type, count, and token preference selection - Logs separate step generation for assignees and reviewers 3. **pkg/workflow/time_delta.go** (timeDeltaLog) - Added logging for time delta parsing operations - Logs input parameters and validation results - Logs successful parsing with formatted output - Logs absolute date-time parsing with multiple format attempts 4. **pkg/workflow/xml_comments.go** (xmlCommentsLog) - Added logging for XML comment removal process - Logs input line count and code block detection - Logs removal completion with statistics 5. **pkg/workflow/secret_masking.go** (secretMaskingLog) - Enhanced existing logging in extractSecretMaskingConfig - Logs extraction entry, steps count, and configuration status - Note: File already had extensive logging in MergeSecretMasking All logging follows best practices: - No side effects in logger arguments - Meaningful debug messages for troubleshooting - Logger naming convention: pkg:filename - Strategic placement at function entry and key decision points 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
pelikhan
approved these changes
Nov 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive debug logging to 5 workflow files to improve troubleshooting and development visibility. All changes follow the project's logging guidelines from AGENTS.md.
Files Enhanced
1. pkg/workflow/manual_approval.go
manualApprovalLog(workflow:manual_approval)2. pkg/workflow/copilot_participant_steps.go
copilotParticipantLog(workflow:copilot_participant_steps)3. pkg/workflow/time_delta.go
timeDeltaLog(workflow:time_delta)4. pkg/workflow/xml_comments.go
xmlCommentsLog(workflow:xml_comments)5. pkg/workflow/secret_masking.go
secretMaskingLog(defined inredact_secrets.go)Validation
✅ Build: Compiled successfully with
make build✅ Testing: Verified logging output with
DEBUG=* ./gh-aw compile dev✅ No Side Effects: All logger arguments are pure values, no function calls
✅ Naming Convention: All loggers follow
pkg:filenamepatternLogging Best Practices Followed
pkg:filename*_test.go) not modifiedExample Output
Cache Updated
The logging enhancement cache has been updated to track these 5 new files, bringing the total to 25 files with enhanced logging across the codebase.
🤖 Generated with Claude Code