Fix integration-tag test build by making initTestGitRepo helper available to all test variants#34841
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
May 26, 2026 02:34
View session
Collaborator
|
@copilot fix more runs with the same fix |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an incorrect !integration build constraint so the shared initTestGitRepo test helper in pkg/cli is available during both unit and -tags integration test builds, fixing integration-tag compile failures due to undefined: initTestGitRepo.
Changes:
- Removed
//go:build !integrationfrompkg/cli/test_helpers_git_test.goto include the helper in integration-tagged test compilation.
Show a summary per file
| File | Description |
|---|---|
| pkg/cli/test_helpers_git_test.go | Makes initTestGitRepo compile in integration-tagged test runs by removing the !integration build constraint. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
github-actions Bot
added a commit
that referenced
this pull request
May 26, 2026
- Updated mapping audit (Section 7.2) to 2026-05-26 review cycle - Evaluated three security items from PR #34841 (commit 34e5154): 1. heredoc_validation.go — already mapped under CTR-006; no change 2. MCP actor validation (--validate-actor) — runtime RBAC, not compiler detection 3. Cross-repo allowlist (SEC-005) — CTR-005/CTR-012 boundary; no new CTR rule - Bumped spec version 1.0.11 → 1.0.12 - Added 1.0.12 change log entry - Updated Section 2 sync table with 1.0.12 row Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI’s unauthenticated integration test job failed at compile time because multiple
pkg/clitests referenceinitTestGitRepo, but that helper was excluded under-tags integration. This change removes the exclusion so the shared test helper is compiled for both unit and integration-tagged test runs.Root cause
pkg/cli/test_helpers_git_test.gohad//go:build !integration, which droppedinitTestGitRepofrom integration builds.undefined: initTestGitRepoacross severalpkg/clitest files.Change
!integrationbuild constraint frompkg/cli/test_helpers_git_test.go.Impact
initTestGitRepois now available to allpkg/clitest targets that rely on it, including integration-tagged runs.