[log] Add debug logging to 5 pkg files#35119
Merged
Merged
Conversation
- workflow/safe_outputs_patch_workspace.go: new logger + 5 calls covering each early-return branch and the inject success path - parser/import_remote.go: dedicated logger replaces shared importLog; logs spec parsing entry and invalid-spec rejection - parser/schedule_cron_detection.go: dedicated logger replaces shared parserLog for cron classification calls - parser/schema_errors.go: dedicated logger replaces shared parserLog for schema-error rewriting calls - workflow/parse_helpers.go: file-level logger added as fallback for callers that pass nil debugLog
pelikhan
approved these changes
May 27, 2026
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add debug logging to 5 pkg files
Summary
Introduces dedicated, file-scoped loggers and adds debug log coverage across five packages to improve observability of parser and workflow internals.
Changes
pkg/parser/import_remote.goimportRemoteLoglogger, replacing the sharedimportLogparseRemoteOriginto trace entry into that functionpkg/parser/schedule_cron_detection.gocronDetectionLoglogger, replacing the sharedparserLogin all cron detection functionspkg/parser/schema_errors.goschemaErrorsLoglogger, replacing the sharedparserLogacross schema error formatting and frontmatter-bounds functionspkg/workflow/parse_helpers.goparseHelpersLogloggerdebugLogis provided, covering coercion and type-skip events that were previously silentpkg/workflow/safe_outputs_patch_workspace.gopatchWorkspaceLogloggerinjectCurrentCheckoutPatchWorkspacePathImpact
parse_helpers.goandsafe_outputs_patch_workspace.gonow emit diagnostic messages