Skip to content

[log] Add debug logging to 5 pkg files#35119

Merged
pelikhan merged 1 commit into
mainfrom
add-debug-logging-2026-05-27-cfc63851de0b1b87
May 27, 2026
Merged

[log] Add debug logging to 5 pkg files#35119
pelikhan merged 1 commit into
mainfrom
add-debug-logging-2026-05-27-cfc63851de0b1b87

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented May 27, 2026

Add debug logging to 5 pkg files

Summary

Introduces dedicated, file-scoped loggers and adds debug log coverage across five packages to improve observability of parser and workflow internals.

Changes

pkg/parser/import_remote.go

  • Added importRemoteLog logger, replacing the shared importLog
  • Added a new log line at the start of parseRemoteOrigin to trace entry into that function

pkg/parser/schedule_cron_detection.go

  • Added cronDetectionLog logger, replacing the shared parserLog in all cron detection functions

pkg/parser/schema_errors.go

  • Added schemaErrorsLog logger, replacing the shared parserLog across schema error formatting and frontmatter-bounds functions

pkg/workflow/parse_helpers.go

  • Added parseHelpersLog logger
  • Added fallback log statements for code paths where no caller-supplied debugLog is provided, covering coercion and type-skip events that were previously silent

pkg/workflow/safe_outputs_patch_workspace.go

  • Added patchWorkspaceLog logger
  • Added diagnostic log lines for every early-return branch and the successful injection path in injectCurrentCheckoutPatchWorkspacePath

Impact

  • Breaking: No
  • Risk: Low — logging-only changes with no behavioural modifications
  • Observability: Each file now owns its own logger, making it easier to filter debug output per component; previously silent code paths in parse_helpers.go and safe_outputs_patch_workspace.go now emit diagnostic messages

Generated by PR Description Updater for issue #35119 · sonnet46 1.1M ·

- workflow/safe_outputs_patch_workspace.go: new logger + 5 calls covering each early-return branch and the inject success path
- parser/import_remote.go: dedicated logger replaces shared importLog; logs spec parsing entry and invalid-spec rejection
- parser/schedule_cron_detection.go: dedicated logger replaces shared parserLog for cron classification calls
- parser/schema_errors.go: dedicated logger replaces shared parserLog for schema-error rewriting calls
- workflow/parse_helpers.go: file-level logger added as fallback for callers that pass nil debugLog
@github-actions github-actions Bot added automation enhancement New feature or request labels May 27, 2026
@pelikhan pelikhan merged commit f404677 into main May 27, 2026
@pelikhan pelikhan deleted the add-debug-logging-2026-05-27-cfc63851de0b1b87 branch May 27, 2026 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant