Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[docs] docs: unbloat engines.md (507 → 398 lines, 21% reduction) #35263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
[docs] docs: unbloat engines.md (507 → 398 lines, 21% reduction) #35263
Changes from all commits
cb1c67cFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/grill-with-docs] The merged GHEC/GHES example omits the GHES-specific
network.allowedentry for the on-prem GitHub hostname.The original GHES example included
github.company.cominnetwork.allowedalongside the Copilot API hostname. GHES workflows typically need both: the Copilot endpoint and the GitHub Enterprise Server hostname. The merged example only shows the Copilot API hostname, which may leave GHES users wondering why their requests are blocked.💡 Suggested addition
Add a prose note after the example:
Or add it as a comment in the YAML block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/grill-with-docs]
COPILOT_PROVIDER_TYPE: anthropicis now uncommented, which may mislead readers into always setting it.The original example had this line commented out (e.g.
# COPILOT_PROVIDER_TYPE: anthropic) to convey that OpenAI-compatible is the default and this field is only needed when switching to a different provider type. The updated example uncomments it, making it look like a required field — or thatanthropicis the default.💡 Suggested fix
Restore the commented form to preserve intent:
Or use a placeholder that makes the optional nature clear:
# COPILOT_PROVIDER_TYPE: openai # default; use "anthropic" or "azure" if neededThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/grill-with-docs] The legacy
engine.argscompatibility note was removed without replacement.The original had a dedicated subsection explaining that
engine.args: ["--permission-mode", "..."]continues to work and that gh-aw strips and subsumes the flag ifengine.permission-modeis also set. Users who have existing workflows using the legacy form will no longer find any documentation explaining this behavior, and may be confused about whether their configs are still supported.💡 Suggested fix
Add a one-sentence note inline, e.g.:
Uh oh!
There was an error while loading. Please reload this page.