Skip to content

Widen review_path_unresolved_422 safe-output fallback to match 'Path could not be resolved'#35275

Merged
pelikhan merged 4 commits into
mainfrom
copilot/deep-report-quick-win-widen-review-path-fallback
May 27, 2026
Merged

Widen review_path_unresolved_422 safe-output fallback to match 'Path could not be resolved'#35275
pelikhan merged 4 commits into
mainfrom
copilot/deep-report-quick-win-widen-review-path-fallback

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 27, 2026

Widens the 422 body-only fallback predicate in actions/setup/js/pr_review_buffer.cjs to match both "Line could not be resolved" and "Path could not be resolved" GitHub API error variants, restoring complete fallback coverage for submit_pull_request_review.

Changes Made

  • pr_review_buffer.cjs: Extended the inline-comment fallback condition to also trigger on "Path could not be resolved" in addition to the existing "Line could not be resolved" check. Both variants now cause the review to be retried as a body-only submission with unanchored comments appended to the review body.
  • pr_review_buffer.test.cjs: Added two new unit tests covering the "Path could not be resolved" variant:
    • Successful body-only retry when the API returns "Path could not be resolved"
    • Failure case when the body-only retry also fails after "Path could not be resolved"

Testing

  • ✅ All 61 pr_review_buffer tests pass
  • ✅ Both "Line could not be resolved" and "Path could not be resolved" trigger the body-only fallback

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/34070dcd-9df7-4c46-a7d2-af5acdb7d3b0

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
@pelikhan
Copy link
Copy Markdown
Collaborator

@copilot keep working

…uld not be resolved'

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 27, 2026

@copilot keep working

Done. In pr_review_buffer.cjs (line 554), I widened the predicate from only matching "Line could not be resolved" to also match "Path could not be resolved". Two new unit tests cover both the success-retry and failure-retry paths for the Path variant. All 61 tests pass (commit fix: widen review_path_unresolved_422 fallback to also match 'Path could not be resolved').

Copilot AI changed the title [WIP] Widen review_path_unresolved_422 safe-output fallback to match 'Path could not be resolved' Widen review_path_unresolved_422 safe-output fallback to match 'Path could not be resolved' May 27, 2026
Copilot AI requested a review from pelikhan May 27, 2026 18:38
@pelikhan pelikhan marked this pull request as ready for review May 27, 2026 18:40
Copilot AI review requested due to automatic review settings May 27, 2026 18:40
@pelikhan
Copy link
Copy Markdown
Collaborator

@copilot merge main and recompile

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR widens the PR review submission fallback so unresolved inline comment paths, like unresolved lines, are retried as body-only reviews with comments preserved in the review body.

Changes:

  • Extends the fallback predicate to match "Path could not be resolved".
  • Adds unit tests for successful and failed body-only retries after path-resolution errors.
  • Updates several generated workflow lockfiles to use Node 24.
Show a summary per file
File Description
actions/setup/js/pr_review_buffer.cjs Adds "Path could not be resolved" to the body-only fallback condition.
actions/setup/js/pr_review_buffer.test.cjs Covers success and retry-failure behavior for the new path-resolution fallback.
.github/workflows/daily-news.lock.yml Changes the workflow Node runtime from 22 to 24.
.github/workflows/daily-issues-report.lock.yml Changes the workflow Node runtime from 22 to 24.
.github/workflows/daily-fact.lock.yml Changes workflow Node runtimes and regenerated heredoc delimiters.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 5/5 changed files
  • Comments generated: 4

uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: '22'
node-version: '24'
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: '22'
node-version: '24'
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: '22'
node-version: '24'
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: '22'
node-version: '24'
@pelikhan
Copy link
Copy Markdown
Collaborator

@copilot make merge-main

…uick-win-widen-review-path-fallback

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 27, 2026

@copilot merge main and recompile

Done. Fetched and merged origin/main (resolving the daily-fact.lock.yml conflict by taking the main version), then ran make build && make recompile — all 236 workflow lock files compiled successfully with 0 errors. The merge commit is 7555077adb.

Copilot AI requested a review from pelikhan May 27, 2026 18:51
@pelikhan pelikhan merged commit 51c1a43 into main May 27, 2026
1 check failed
@pelikhan pelikhan deleted the copilot/deep-report-quick-win-widen-review-path-fallback branch May 27, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[deep-report] [quick-win] Widen review_path_unresolved_422 safe-output fallback to match "Path could not be resolved"

4 participants