Widen review_path_unresolved_422 safe-output fallback to match 'Path could not be resolved'#35275
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/34070dcd-9df7-4c46-a7d2-af5acdb7d3b0 Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
|
@copilot keep working |
…uld not be resolved' Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done. In |
|
@copilot merge main and recompile |
There was a problem hiding this comment.
Pull request overview
This PR widens the PR review submission fallback so unresolved inline comment paths, like unresolved lines, are retried as body-only reviews with comments preserved in the review body.
Changes:
- Extends the fallback predicate to match
"Path could not be resolved". - Adds unit tests for successful and failed body-only retries after path-resolution errors.
- Updates several generated workflow lockfiles to use Node 24.
Show a summary per file
| File | Description |
|---|---|
actions/setup/js/pr_review_buffer.cjs |
Adds "Path could not be resolved" to the body-only fallback condition. |
actions/setup/js/pr_review_buffer.test.cjs |
Covers success and retry-failure behavior for the new path-resolution fallback. |
.github/workflows/daily-news.lock.yml |
Changes the workflow Node runtime from 22 to 24. |
.github/workflows/daily-issues-report.lock.yml |
Changes the workflow Node runtime from 22 to 24. |
.github/workflows/daily-fact.lock.yml |
Changes workflow Node runtimes and regenerated heredoc delimiters. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 5/5 changed files
- Comments generated: 4
| uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | ||
| with: | ||
| node-version: '22' | ||
| node-version: '24' |
| uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | ||
| with: | ||
| node-version: '22' | ||
| node-version: '24' |
| uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | ||
| with: | ||
| node-version: '22' | ||
| node-version: '24' |
| uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | ||
| with: | ||
| node-version: '22' | ||
| node-version: '24' |
|
@copilot make merge-main |
…uick-win-widen-review-path-fallback Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done. Fetched and merged |
Widens the 422 body-only fallback predicate in
actions/setup/js/pr_review_buffer.cjsto match both"Line could not be resolved"and"Path could not be resolved"GitHub API error variants, restoring complete fallback coverage forsubmit_pull_request_review.Changes Made
pr_review_buffer.cjs: Extended the inline-comment fallback condition to also trigger on"Path could not be resolved"in addition to the existing"Line could not be resolved"check. Both variants now cause the review to be retried as a body-only submission with unanchored comments appended to the review body.pr_review_buffer.test.cjs: Added two new unit tests covering the"Path could not be resolved"variant:"Path could not be resolved""Path could not be resolved"Testing
pr_review_buffertests pass"Line could not be resolved"and"Path could not be resolved"trigger the body-only fallback