Preserve setup-node steps that use node-version-file during runtime deduplication#35321
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for node-version-file in setup-node steps
Preserve May 27, 2026
setup-node steps that use node-version-file during runtime deduplication
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes runtime deduplication so user-authored actions/setup-node steps that select Node.js via node-version-file are preserved instead of being replaced by generated Node setup.
Changes:
- Treat non-empty
with.node-version-fileon Node setup steps as customization. - Filter the Node runtime requirement when such a customized setup step is preserved.
- Add regression coverage for the
node-version-filescenario.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/runtime_deduplication.go |
Updates Node setup customization detection to preserve node-version-file usage. |
pkg/workflow/runtime_setup_test.go |
Adds regression test covering preservation of user node-version-file setup. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
pelikhan
approved these changes
May 27, 2026
pelikhan
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/setup-nodesteps configured withwith.node-version-filewere treated as non-custom and removed by runtime deduplication. This could cause the compiler to inject a generatednode-version, effectively bypassing the user’s version-file-based setup intent.Runtime deduplication behavior
DeduplicateRuntimeSetupStepsFromCustomStepsto treat non-emptywith.node-version-fileas user customization.setup-nodestep is preserved and Node runtime auto-injection is filtered out for that workflow.Regression coverage
TestDeduplicatePreservesUserNodeVersionFileto lock expected behavior:setup-nodestep usingnode-version-filenode-version: '24'Illustrative case
With this change, the above step remains authoritative instead of being replaced by a generated setup step.