Tighten Sub-Issue Closer add_comment target contract#35590
Merged
Conversation
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix safe_outputs validation for add_comment in sub-issue closer
Tighten Sub-Issue Closer add_comment target contract
May 28, 2026
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sub-Issue Closer was still emitting
add_commentsafe outputs without a numeric target undertarget: "*", so the post-stepsafe_outputsjob rejected every comment even though the agent run completed. This aligns the workflow prompt with the earlier fix pattern already applied to other affected workflows.Workflow prompt contract
add_commentemitted by Sub-Issue Closer to includeissue_number.add_commentitems whentarget: "*"is configured.update_issueand the matchingadd_comment.Regression coverage
sub-issue-closer.md.pr-sous-chef.mdandcontribution-check.md.Expected emitted shape
{ "type": "add_comment", "issue_number": 123, "body": "🎉 **Automatically closed by Sub-Issue Closer**\n\nAll sub-issues have been completed." }