Skip to content

Tighten Sub-Issue Closer add_comment target contract#35590

Merged
pelikhan merged 2 commits into
mainfrom
copilot/aw-failures-fix-safe-outputs-validation
May 29, 2026
Merged

Tighten Sub-Issue Closer add_comment target contract#35590
pelikhan merged 2 commits into
mainfrom
copilot/aw-failures-fix-safe-outputs-validation

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 28, 2026

Sub-Issue Closer was still emitting add_comment safe outputs without a numeric target under target: "*", so the post-step safe_outputs job rejected every comment even though the agent run completed. This aligns the workflow prompt with the earlier fix pattern already applied to other affected workflows.

  • Workflow prompt contract

    • Require every add_comment emitted by Sub-Issue Closer to include issue_number.
    • Explicitly forbid targetless add_comment items when target: "*" is configured.
    • Instruct the workflow to reuse the same parent issue number for both update_issue and the matching add_comment.
  • Regression coverage

    • Add a focused workflow contract test for sub-issue-closer.md.
    • Lock in the same guardrails already covered for pr-sous-chef.md and contribution-check.md.
  • Expected emitted shape

    {
      "type": "add_comment",
      "issue_number": 123,
      "body": "🎉 **Automatically closed by Sub-Issue Closer**\n\nAll sub-issues have been completed."
    }

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix safe_outputs validation for add_comment in sub-issue closer Tighten Sub-Issue Closer add_comment target contract May 28, 2026
Copilot AI requested a review from gh-aw-bot May 28, 2026 23:13
@pelikhan pelikhan marked this pull request as ready for review May 29, 2026 00:02
Copilot AI review requested due to automatic review settings May 29, 2026 00:02
@pelikhan pelikhan merged commit e077561 into main May 29, 2026
@pelikhan pelikhan deleted the copilot/aw-failures-fix-safe-outputs-validation branch May 29, 2026 00:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw-failures] Sub-Issue Closer regresses safe_outputs add_comment validation — #35352 fix did not cover this workflow

4 participants