Skip to content

docs(outcomes): sync Outcome States and Accepted Outcomes table with Safe Output Outcome Evaluation spec#35633

Merged
mnkiefer merged 3 commits into
mainfrom
copilot/update-outcome-docs
May 29, 2026
Merged

docs(outcomes): sync Outcome States and Accepted Outcomes table with Safe Output Outcome Evaluation spec#35633
mnkiefer merged 3 commits into
mainfrom
copilot/update-outcome-docs

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 29, 2026

The Outcomes reference doc was stale relative to the Safe Output Outcome Evaluation spec: lifecycle states were missing, noop was misclassified as an outcome state, and four output types that gained dedicated evaluators still showed fallback rule.

Outcome States table

  • Added lifecycle and lifecycle_close as first-class outcome states (previously deferred to spec as "extended lifecycle details")
  • Removed noop — it is a safe output type, not an outcome state

Accepted Outcomes table

Four rows updated from fallback rule to dedicated rule with accurate accepted descriptions:

Safe output type Before After
add_reviewer review target exists / fallback reviewer acted or request remained/was removed / dedicated
update_issue issue still exists / fallback intended edit still matches current issue state / dedicated
update_pull_request PR still exists / fallback intended edit still matches current PR state / dedicated
submit_pull_request_review PR still exists / fallback review affected PR lifecycle / dedicated

Copilot AI and others added 2 commits May 28, 2026 19:32
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
@mnkiefer mnkiefer marked this pull request as ready for review May 29, 2026 04:48
Copilot AI review requested due to automatic review settings May 29, 2026 04:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Outcomes reference documentation to match the current Safe Output Outcome Evaluation spec, including correcting the set of outcome states and the accepted-outcomes evaluation sources for several safe output types; additionally includes a regenerated outcome-collector workflow lock file.

Changes:

  • Updated Outcome States docs: removed noop as an outcome state and added lifecycle / lifecycle_close.
  • Updated Accepted Outcomes docs for add_reviewer, update_issue, update_pull_request, and submit_pull_request_review from “fallback rule” to “dedicated rule” with updated “accepted” descriptions.
  • Regenerated .github/workflows/outcome-collector.lock.yml (schema/version/container/action wiring and related workflow content changed).
Show a summary per file
File Description
docs/src/content/docs/reference/outcomes.md Synces Outcome States and Accepted Outcomes tables with the Safe Output Outcome Evaluation spec.
.github/workflows/outcome-collector.lock.yml Regenerated workflow lock file (updates pinned images/metadata and workflow steps).

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 1

Comment thread .github/workflows/outcome-collector.lock.yml Outdated
@mnkiefer
Copy link
Copy Markdown
Collaborator

@copilot Revert changes to .github/workflows/outcome-collector.lock.yml‎.

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 29, 2026

@copilot Revert changes to .github/workflows/outcome-collector.lock.yml‎.

Done — reverted in 3c5c29a.

Copilot AI requested a review from mnkiefer May 29, 2026 05:12
@mnkiefer mnkiefer merged commit 279d5ef into main May 29, 2026
7 checks passed
@mnkiefer mnkiefer deleted the copilot/update-outcome-docs branch May 29, 2026 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants