CI: enforce regexpcompileinfunction and fprintlnsprintf in custom linter gate#35690
Merged
pelikhan merged 2 commits intoMay 29, 2026
Merged
Conversation
4 tasks
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enforce regexpcompileinfunction and fprintlnsprintf analyzers in CI
CI: enforce May 29, 2026
regexpcompileinfunction and fprintlnsprintf in custom linter gate
pelikhan
approved these changes
May 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CI’s custom-linter gate to explicitly enforce two already-registered custom Go analyzers (regexpcompileinfunction and fprintlnsprintf), aligning the workflow with the analyzer set maintained in cmd/linters/main.go.
Changes:
- Extend the
make golint-customLINTER_FLAGSin.github/workflows/cgo.ymlto include-regexpcompileinfunction. - Extend the same enforced set to include
-fprintlnsprintf.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/cgo.yml | Adds two custom analyzer flags to the CI “Run custom linters” step so the CI gate matches the maintained analyzer set. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sergo R22 identified two registered custom analyzers that were not included in CI’s enforced
LINTER_FLAGS, despite having zero production diagnostics. This PR aligns CI enforcement with the analyzer set already maintained incmd/linters/main.goto prevent future regressions.What changed
.github/workflows/cgo.yml(Run custom linters) to include:-regexpcompileinfunction-fprintlnsprintfImpact
fmt.Fprintln(w, fmt.Sprintf(...))patternsWorkflow diff