fix: use 1s benchtime for CLI helper benchmarks to eliminate false regressions

[Copilot]

The daily-cli-performance workflow was reporting a false +45.7% regression in BenchmarkFindIncludesInContent (3,516 ns/op vs historical 2,413 ns/op). Both values were fabricated by measurement noise—the function's true steady-state cost is ~160 ns/op.

Root cause

bench-performance ran CLI helper benchmarks with -benchtime=3x (3 iterations). For a ~160 ns/op function, b.Loop() setup overhead and OS scheduling jitter dominate at that sample count, inflating measurements ~22×:

benchtime	FindIncludesInContent	ExtractWorkflowNameFromFile
3x (before)	~3,366–3,523 ns/op 📈	~12,136 ns/op 📈
1s (after)	~159–160 ns/op ✅	~6,779 ns/op ✅

Fix

Changed -benchtime=3x → -benchtime=1s for the CLI helper benchmark line in Makefile. The workflow benchmarks in pkg/workflow (slow, O(100ms+) each) retain 3x to keep CI runtime bounded.

-go test -bench='Benchmark(ExtractWorkflowNameFromFile|FindIncludesInContent)$$' \
-    -benchmem -benchtime=3x -run=^$$ ./pkg/cli >> bench_performance.txt
+go test -bench='Benchmark(ExtractWorkflowNameFromFile|FindIncludesInContent)$$' \
+    -benchmem -benchtime=1s -run=^$$ ./pkg/cli >> bench_performance.txt

With 1s, FindIncludesInContent accumulates ~7M iterations yielding measurements stable to <1% variance across runs.

[Copilot]

Pull request overview

Fixes false-positive regression alerts in the daily CLI performance workflow by switching the CLI helper benchmarks from a fixed 3-iteration count to a 1-second duration, which provides stable measurements for sub-microsecond functions.

Changes:

• Update bench-performance target's CLI helper benchmark invocation from -benchtime=3x to -benchtime=1s.

Show a summary per file

File	Description
Makefile	Increases sample size for ExtractWorkflowNameFromFile and FindIncludesInContent benchmarks to eliminate measurement noise.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0