Skip to content

Remove deprecated Copilot model aliases from built-in alias and multiplier registries#35786

Merged
pelikhan merged 4 commits into
mainfrom
copilot/remove-copilot-models
May 29, 2026
Merged

Remove deprecated Copilot model aliases from built-in alias and multiplier registries#35786
pelikhan merged 4 commits into
mainfrom
copilot/remove-copilot-models

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 29, 2026

This change removes gpt-4o-mini, gpt-4.1, gpt-4o, and gpt-5.4-nano from the Copilot-facing built-in model alias/multiplier surface, and adds guardrails so they are not reintroduced via routine data updates.

  • Built-in alias map cleanup

    • Removed the gpt-4.1 alias from /home/runner/work/gh-aw/gh-aw/pkg/workflow/data/model_aliases.json.
    • Updated alias expectations in /home/runner/work/gh-aw/gh-aw/pkg/workflow/model_aliases_test.go to reflect the removed key.
  • Model multiplier registry cleanup

    • Removed gpt-4o-mini, gpt-4.1, gpt-4o, and gpt-5.4-nano from:
      • /home/runner/work/gh-aw/gh-aw/pkg/cli/data/model_multipliers.json
      • /home/runner/work/gh-aw/gh-aw/actions/setup/js/model_multipliers.json
    • This keeps runtime and setup-action multiplier sources aligned.
  • Regression prevention

    • Added explicit negative assertions in /home/runner/work/gh-aw/gh-aw/pkg/cli/effective_tokens_test.go to ensure the removed model IDs stay absent.
  • Generated/docs alignment

    • Updated model tables in /home/runner/work/gh-aw/gh-aw/docs/src/content/docs/reference/model-tables.md.
    • Refreshed impacted wasm golden fixtures after alias output changes.
{
  "aliases": {
    "gpt-4.1": ["copilot/gpt-4.1*", "openai/gpt-4.1*"]
  },
  "multipliers": {
    "gpt-4o": 0.33,
    "gpt-4o-mini": 0.33,
    "gpt-4.1": 1.0,
    "gpt-5.4-nano": 6.0
  }
}

After this PR, those entries are intentionally absent from built-in alias/multiplier data.

Copilot AI and others added 2 commits May 29, 2026 21:09
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title Remove deprecated Copilot model aliases Remove deprecated Copilot model aliases from built-in alias and multiplier registries May 29, 2026
Copilot AI requested a review from pelikhan May 29, 2026 21:19
@pelikhan pelikhan marked this pull request as ready for review May 29, 2026 21:27
Copilot AI review requested due to automatic review settings May 29, 2026 21:27
@pelikhan
Copy link
Copy Markdown
Collaborator

@copilot update the agentic workflow model multiplier update to keep ignoring these models. make recompile.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes deprecated Copilot model aliases (gpt-4o, gpt-4o-mini, gpt-4.1, gpt-5.4-nano) from the built-in alias and multiplier registries, updates tests with negative-assertion guardrails, and refreshes generated docs/golden fixtures.

Changes:

  • Drop gpt-4.1 from model_aliases.json (and updated alias-family expectations + a NotContains assertion in tests).
  • Drop gpt-4o, gpt-4o-mini, gpt-4.1, gpt-5.4-nano from both pkg/cli/data/model_multipliers.json and actions/setup/js/model_multipliers.json, with a new test (TestModelMultipliersRemovedCopilotAliases) guarding regression.
  • Regenerate docs/reference/model-tables.md and refresh affected wasm golden fixtures to reflect the smaller alias/multiplier surface.
Show a summary per file
File Description
pkg/workflow/data/model_aliases.json Remove deprecated gpt-4.1 builtin alias
pkg/workflow/model_aliases.go Doc comment updated to drop gpt-4.1 from the listed families
pkg/workflow/model_aliases_test.go Adjust family lists; add negative assertion for gpt-4.1
pkg/cli/data/model_multipliers.json Remove deprecated multiplier keys
actions/setup/js/model_multipliers.json Mirror multiplier removals for setup-action source
pkg/cli/effective_tokens_test.go Drop removed gpt-5.4-nano assertion; add NotContains regression test
docs/src/content/docs/reference/model-tables.md Regenerated tables without removed entries
pkg/workflow/testdata/TestWasmGolden_/.golden Refresh emitted AWF config to drop gpt-4.1 from apiProxy.models

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 16/16 changed files
  • Comments generated: 0

Copilot AI and others added 2 commits May 29, 2026 21:38
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 29, 2026

@copilot update the agentic workflow model multiplier update to keep ignoring these models. make recompile.

Addressed in cd05179.

@github-actions
Copy link
Copy Markdown
Contributor

``
@copilot request a fresh check run to clear the BLOCKED merge state.

Generated by 👨‍🍳 PR Sous Chef · gpt54 15.5M ·

@pelikhan pelikhan merged commit 82fe25b into main May 29, 2026
@pelikhan pelikhan deleted the copilot/remove-copilot-models branch May 29, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants