Fix PR link formatting in cli-version-checker workflow#3586
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a documentation issue where the cli-version-checker workflow was creating issues with ambiguous PR/issue references (like #6211) that incorrectly linked to the gh-aw repository instead of external repositories (openai/codex, github/github-mcp-server). The fix adds explicit instructions to convert these short references to full URLs.
Key changes:
- Added CRITICAL instructions in the "GitHub Release Notes" section for Codex and GitHub MCP Server to convert short PR references to full URLs
- Added a new "Pull Request Link Formatting" section with clear examples of correct vs incorrect formatting
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/cli-version-checker.md |
Added instructions to convert PR/issue references to full URLs in two sections: GitHub Release Notes (lines 72, 75) and new Pull Request Link Formatting section (lines 128-132) |
.github/workflows/cli-version-checker.lock.yml |
Auto-generated compiled version reflecting the same changes as the .md file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - **CRITICAL**: Convert PR/issue references (e.g., `#6211`) to full URLs since they refer to external repositories (e.g., `https://github.com/openai/codex/pull/6211`) | ||
| - **GitHub MCP Server**: Fetch release notes from https://github.com/github/github-mcp-server/releases/tag/v{VERSION} | ||
| - Parse release body for changelog entries | ||
| - **CRITICAL**: Convert PR/issue references (e.g., `#1105`) to full URLs since they refer to external repositories (e.g., `https://github.com/github/github-mcp-server/pull/1105`) |
There was a problem hiding this comment.
The instruction mentions 'PR/issue references' but only provides an example URL format for pull requests (/pull/). Consider adding an example for issue references as well (e.g., https://github.com/openai/codex/issues/1234) to cover both cases mentioned in the text.
| - **CRITICAL**: Convert PR/issue references (e.g., `#6211`) to full URLs since they refer to external repositories (e.g., `https://github.com/openai/codex/pull/6211`) | |
| - **GitHub MCP Server**: Fetch release notes from https://github.com/github/github-mcp-server/releases/tag/v{VERSION} | |
| - Parse release body for changelog entries | |
| - **CRITICAL**: Convert PR/issue references (e.g., `#1105`) to full URLs since they refer to external repositories (e.g., `https://github.com/github/github-mcp-server/pull/1105`) | |
| - **CRITICAL**: Convert PR/issue references (e.g., `#6211`) to full URLs since they refer to external repositories (e.g., `https://github.com/openai/codex/pull/6211` for PRs, `https://github.com/openai/codex/issues/1234` for issues) | |
| - **GitHub MCP Server**: Fetch release notes from https://github.com/github/github-mcp-server/releases/tag/v{VERSION} | |
| - Parse release body for changelog entries | |
| - **CRITICAL**: Convert PR/issue references (e.g., `#1105`) to full URLs since they refer to external repositories (e.g., `https://github.com/github/github-mcp-server/pull/1105` for PRs, `https://github.com/github/github-mcp-server/issues/1105` for issues) |
| - **CRITICAL**: Always use full URLs for pull requests that refer to external repositories | ||
| - **CORRECT**: https://github.com/openai/codex/pull/6211 | ||
| - **INCORRECT**: #6211 (relative reference only works for same repository) | ||
| - When copying PR references from release notes, convert `#1234` to full URLs like `https://github.com/owner/repo/pull/1234` |
There was a problem hiding this comment.
For consistency with line 72 and 75, this instruction should also mention issue references in addition to PR references, and use 'PR/issue references' to match the terminology used earlier in the document.
| - When copying PR references from release notes, convert `#1234` to full URLs like `https://github.com/owner/repo/pull/1234` | |
| - When copying PR/issue references from release notes, convert `#1234` to full URLs like `https://github.com/owner/repo/pull/1234` for PRs or `https://github.com/owner/repo/issues/1234` for issues |
The
cli-version-checkerworkflow creates issues about CLI updates that include PR references from external repositories (openai/codex, github/github-mcp-server). These short references like#6211incorrectly link to non-existent gh-aw PRs instead of the intended external repository.Changes
GitHub Release Notes section: Added CRITICAL instructions to convert PR/issue references to full URLs for Codex and GitHub MCP Server
#6211→https://github.com/openai/codex/pull/6211#1105→https://github.com/github/github-mcp-server/pull/1105New Pull Request Link Formatting section: Added dedicated guidance with examples
#1234references only work within same repositoryExample
When processing Codex release notes, the workflow will now convert:
Addresses feedback from issue #3571.
Original prompt
This section details on the original issue you should resolve
<issue_title>[q] Fix PR link formatting in cli-version-checker workflow</issue_title>
<issue_description># Q Workflow Optimization Report
Context
This fix addresses feedback from issue #3571 where
@pelikhanrequested: "/q the workflow should specify that the links to pull requests must use full links as they refer to another repo."Issue Found (from issue #3571)
The
cli-version-checkerworkflow creates issues about CLI version updates that include pull request references from external repositories (openai/codex, github/github-mcp-server). However, the workflow instructions didn't explicitly specify that PR references like#6211must be converted to full URLs when they refer to external repositories.Example from issue #3571:
#6211,#6230,#3643, etc.#6211would incorrectly link to a non-existent PR in gh-awChanges Made
.github/workflows/cli-version-checker.md
1. Enhanced GitHub Release Notes Instructions (lines 68-76)
#1234→https://github.com/owner/repo/pull/12342. Added Pull Request Link Formatting Section (lines 127-132)
#1234style references only work within the same repositoryExpected Improvements
Validation
Changes validated:
Note: .lock.yml file will be generated automatically after merge via GitHub Actions.
References
Show patch preview (46 of 46 lines)