Skip to content

SPDD follow-ups: guard-policy integration coverage, aw.yml version/metadata schema, and spec sync updates#35953

Closed
Copilot wants to merge 5 commits into
mainfrom
copilot/spdd-daily-spec-work-plan
Closed

SPDD follow-ups: guard-policy integration coverage, aw.yml version/metadata schema, and spec sync updates#35953
Copilot wants to merge 5 commits into
mainfrom
copilot/spdd-daily-spec-work-plan

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 30, 2026

This PR implements the SPDD queue items for 2026-05-30 by closing documentation/code drift across guard policies, package manifest constraints, and access-control/safe-output spec gaps. It adds missing guard-policy compilation coverage and aligns aw.yml validation with newly specified manifest fields.

  • Guard policy end-to-end coverage

    • Added integration-style compilation test to validate guard policy propagation into compiled lock workflows:
      • pkg/workflow/tools_guard_policy_integration_test.go
    • Confirms compiled output contains guard policy envelope and expected allow-only fields.
  • Repository package manifest: new fields + version ceiling

    • Extended schema and parser support for:
      • max-version
      • license
      • tags (bounded list/string length)
      • categories (enum)
    • Added cross-field version constraint validation (min-version cannot exceed max-version).
    • Updated parser helpers for clearer semantics and documented slice parsing behavior.
  • Manifest test coverage expansion

    • Added parser/compile tests for:
      • compatible/incompatible max-version
      • invalid min-version > max-version
      • accepted/rejected metadata fields (license/tags/categories)
      • string-slice field parsing edge cases
  • Spec synchronization updates

    • repository-package-manifest-specification.md
      • Added max-version, metadata fields, validation rules, and package lifecycle section (gh aw add|update|remove) with normative requirements.
    • model-alias-specification.md
      • Expanded §12 compliance matrix coverage and changelog alignment for ?effort= / ?temperature=.
    • guard-policies-specification.md
      • Replaced Open Questions with Decisions (Accepted/Deferred/Out-of-scope).
    • github-mcp-access-control-specification.md
      • Added config-reload/stale-config safeguards.
    • safe-outputs-specification.md
      • Added §10 execution-guarantee audit note with explicit gap markers.
if manifest.MinVersion != "" && manifest.MaxVersion != "" && semverutil.Compare(manifest.MinVersion, manifest.MaxVersion) > 0 {
	return nil, nil, fmt.Errorf(
		"invalid Agentic Workflow manifest %q: min-version %q cannot be greater than max-version %q",
		manifestPath, manifest.MinVersion, manifest.MaxVersion,
	)
}

Copilot AI linked an issue May 30, 2026 that may be closed by this pull request
11 tasks
Copilot AI and others added 4 commits May 30, 2026 16:35
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Copilot AI changed the title [WIP] Add integration tests for guard policy end-to-end compilation SPDD follow-ups: guard-policy integration coverage, aw.yml version/metadata schema, and spec sync updates May 30, 2026
Copilot AI requested a review from gh-aw-bot May 30, 2026 16:40
@pelikhan pelikhan closed this May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[spdd] Daily spec work plan - 2026-05-30

3 participants