Skip to content

Format CJS helpers failing lint-js, merge main, and recompile workflows#36139

Merged
pelikhan merged 3 commits into
mainfrom
copilot/lint-js
May 31, 2026
Merged

Format CJS helpers failing lint-js, merge main, and recompile workflows#36139
pelikhan merged 3 commits into
mainfrom
copilot/lint-js

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 31, 2026

lint-js was failing because Prettier formatting had drifted in three workflow helper modules under actions/setup/js. This change brings those files back into canonical formatting so the JS formatting check passes consistently, and it also merges the latest main branch and recompiles workflow artifacts as requested in review feedback.

  • Scope

    • Reformat:
      • actions/setup/js/check_daily_effective_workflow_guardrail.cjs
      • actions/setup/js/handle_agent_failure.cjs
      • actions/setup/js/setup_threat_detection.cjs
    • Merge main into this branch
    • Recompile workflow lock files and synced action pin artifacts after the merge
  • What changed

    • Normalize long destructuring assignments and function calls to the repository’s current Prettier output.
    • Collapse multi-line warning/message constructions where Prettier now prefers single-line formatting.
    • Merge the latest main changes into the PR branch.
    • Re-run workflow compilation so committed lock files and related generated artifacts match the merged branch state.
  • Representative diff shape

    -const {
    -  calculateDailyEffectiveWorkflowStats,
    -  findTokenUsageFile,
    -  formatEffectiveTokens,
    -  sumEffectiveTokensFromTokenUsageFile,
    -} = require("./daily_effective_workflow_helpers.cjs");
    +const { calculateDailyEffectiveWorkflowStats, findTokenUsageFile, formatEffectiveTokens, sumEffectiveTokensFromTokenUsageFile } = require("./daily_effective_workflow_helpers.cjs");
  • Validation

    • npm run lint:cjs
    • make lint-lock

Copilot AI and others added 2 commits May 31, 2026 16:11
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
Copy link
Copy Markdown
Collaborator

@copilot merge main and recompile

# Conflicts:
#	.github/workflows/daily-cache-strategy-analyzer.lock.yml
#	.github/workflows/daily-fact.lock.yml
#	.github/workflows/daily-observability-report.lock.yml
#	.github/workflows/dev.lock.yml
#	.github/workflows/duplicate-code-detector.lock.yml
#	.github/workflows/grumpy-reviewer.lock.yml
#	.github/workflows/issue-arborist.lock.yml
#	.github/workflows/necromancer.lock.yml
#	.github/workflows/schema-feature-coverage.lock.yml
#	.github/workflows/smoke-call-workflow.lock.yml
#	.github/workflows/smoke-codex.lock.yml

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 31, 2026

@copilot merge main and recompile

Addressed in 787e5ad: merged main into this branch and recompiled the workflow artifacts. Post-merge npm run lint:cjs and make lint-lock both pass.

Copilot AI changed the title Format CJS helpers failing lint-js Format CJS helpers failing lint-js, merge main, and recompile workflows May 31, 2026
Copilot AI requested a review from pelikhan May 31, 2026 16:50
@pelikhan pelikhan marked this pull request as ready for review May 31, 2026 16:54
Copilot AI review requested due to automatic review settings May 31, 2026 16:54
@pelikhan pelikhan merged commit ec22f13 into main May 31, 2026
@pelikhan pelikhan deleted the copilot/lint-js branch May 31, 2026 16:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants