[log] Add debug logging to token/offset/input helpers

[github-actions]

Fix discarded errors and add diagnostic logging to token/offset/input helpers

Summary

This PR addresses two related concerns across the UTC offset, token limit, and input-definition helpers:

1. Bug fix — strconv.Atoi error returns in utc_offset.go were silently discarded; they are now propagated as proper errors.
2. Observability — diagnostic log statements have been added at every notable resolution, rejection, and fallback branch in the affected packages to make misbehaviour easier to trace in production and test runs.

---

Changes by file

File	Kind	Impact	Breaking
pkg/workflow/utc_offset.go	Bug fix + logging	Medium	No
pkg/workflow/daily_effective_workflow.go	Logging	Low	No
pkg/typeutil/effective_token_limits.go	Logging	Low	No
pkg/types/input_definition.go	Logging	Low	No

---

Detail

pkg/workflow/utc_offset.go ⚠️ notable fix

• NormalizeUTCOffset and ParseUTCOffsetLocation both called strconv.Atoi and discarded the returned error. Those errors are now returned to the caller instead of being silently swallowed.
• Added a package-level logger.
• Log statements added for: invalid offset strings, out-of-range offset values, and successful normalization.

pkg/workflow/daily_effective_workflow.go

• Added a package-level logger.
• Every resolution and fallback branch in resolveMaxDailyEffectiveTokens now emits a structured log line, making it straightforward to trace which limit source was applied at runtime.

pkg/typeutil/effective_token_limits.go

• ParseInt64KMSuffix now logs at the two rejection paths: invalid integer input and integer overflow, aiding diagnosis of misconfigured token-limit strings.

pkg/types/input_definition.go

• Added a package-level logger.
• GetDefaultAsString now logs a diagnostic message when it encounters an unexpected default value type, replacing a previously silent no-op branch.

---

Testing notes

• The strconv.Atoi error-propagation change in utc_offset.go is the only behaviour-altering change; callers that previously received a zero value on bad input will now receive an error — verify that all call sites handle the new error return correctly.
• All other changes are purely additive log calls with no change to return values or control flow.

---

Commits

SHA	Message
5a97add	Fix discarded strconv.Atoi error returns in utc_offset.go
b226e86	Add debug logging to token/offset/input helpers

Generated by PR Description Updater for issue #36182 · sonnet46 1M · ◷

[pelikhan]

@copilot lint go https://github.com/github/gh-aw/actions/runs/26736025229/job/78789841141

[Copilot]

@copilot lint go https://github.com/github/gh-aw/actions/runs/26736025229/job/78789841141

Fixed in the latest commit. The custom linter was flagging four discarded error returns from strconv.Atoi in pkg/workflow/utc_offset.go (lines 26, 27, 45, 46). These calls were present in the original code before my changes, but my edits to the file brought them under linter scrutiny. I've updated both NormalizeUTCOffset and ParseUTCOffsetLocation to properly handle the errors instead of silently discarding them with _.