[schema-coverage] feat: add schema coverage demo for private field#36200
Conversation
|
✅ PR Code Quality Reviewer completed the code quality review. No action needed: PR #36200 is already merged. The single changed file (schema-demos/schema-demo-private.md) is a minimal documentation-only demo workflow with no code logic, no Go changes, and no security-sensitive content. Nothing to flag. |
|
🧪 Test Quality Sentinel completed test quality analysis. No test files were added or modified in this PR. The only changed file is schema-demos/schema-demo-private.md (a workflow demo markdown file). Test Quality Sentinel skipped. |
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ |
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. No ADR enforcement needed: PR #36200 does not have the 'implementation' label (has_implementation_label=false) and has 0 new lines of code in business logic directories (requires_adr_by_default_volume=false, threshold=100). Changes are limited to .github skill scripts and an MCP server file outside enforced business-logic paths. |
There was a problem hiding this comment.
Pull request overview
Adds a minimal schema-coverage demo workflow showing how to use the private frontmatter field, aligning with the existing schema-demos/ patterns to improve schema feature coverage.
Changes:
- Add
schema-demos/schema-demo-private.mddemonstratingprivate: truein frontmatter. - Include a minimal
nooptask payload consistent with other schema demo workflows.
Show a summary per file
| File | Description |
|---|---|
| schema-demos/schema-demo-private.md | Adds a minimal frontmatter + noop demo covering the private schema field. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /grill-with-docs — the file follows the established schema-demo pattern accurately, and the private: true semantics are described correctly.
📋 Highlights
Positive Highlights
- ✅ Frontmatter structure is consistent with all other
schema-demos/files - ✅
private: truefield value is correct (boolean, not string) - ✅ Field description accurately reflects the
gh aw addsharing restriction - ✅ Task body properly calls
noop, the right pattern for a coverage-only demo
Minor observation
Build validation was skipped (blocked proxy.golang.org), but this is a known environment limitation noted in the PR description — schema conformance will be verified when CI runs.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 824.7K
Summary
Adds a new schema demo file (
schema-demos/schema-demo-private.md) to document and demonstrate theprivatefrontmatter schema field, achieving 100% schema feature coverage across the demo suite.Changes
Added
schema-demos/schema-demo-private.md— New demo workflow file illustrating theprivatefield in the workflow frontmatter schema. This is a documentation/demo-only addition with no logic changes.Motivation
The
privatefrontmatter field lacked a dedicated demo entry in the schema-demos directory. This gap meant the demo suite did not fully cover all supported schema fields. This PR closes that gap to ensure every schema feature is represented and discoverable.Impact
Checklist