[schema-coverage] feat: add schema coverage demo for run-name field#36205
Conversation
|
🧪 Test Quality Sentinel completed test quality analysis. No test files were added or modified in this PR. The only changed file is schema-demos/schema-demo-run-name.md (a markdown schema demo file). Test Quality Sentinel skipped. |
|
✅ PR Code Quality Reviewer completed the code quality review. |
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. No ADR enforcement needed: PR #36205 does not have the 'implementation' label and has 0 new lines of code in business logic directories (≤100 threshold). The changed files are skill scripts (.github/skills/) and an MCP server config (.github/workflows/shared/mcp/), none of which fall under tracked business logic directories. |
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
No blocking issues. Single new schema-demo markdown file — no logic, no Go code, no security surface. run-name field usage is valid and follows the existing demo pattern.
🔎 Code quality review by PR Code Quality Reviewer · sonnet46 487.6K
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /grill-with-docs — clean, conforming addition. ✅ Approved.
📋 Key Themes & Highlights
Positive Highlights
- ✅ Follows the established
schema-demos/pattern exactly (frontmatter, structure, noop task) - ✅
run-namefield is correctly placed with a valid static string value - ✅ Description, heading, and body text are consistent with other demos in the directory
- ✅ No new abstractions or vocabulary introduced — pure conformance
No Issues Found
No blocking or advisory issues. The file is consistent with every other demo in the directory.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 780.4K
Summary
Adds a new schema-demo workflow file that exercises the
run-namefrontmatter field, completing 100% schema feature coverage for the gh-aw frontmatter spec.Changes
schema-demos/schema-demo-run-name.md(added)run-namefrontmatter field — the last uncovered schema feature.run-name: Schema Demo Runalongside the standard required fields (on,permissions,engine,timeout-minutes).noopsafe-output tool so the workflow is runnable without side effects.run-namedoes (custom label shown in the GitHub Actions UI).Impact Assessment
Commit
b605aa264feat: add schema coverage demo for run-name