Clarify `push_to_pull_request_branch` behavior for multi-checkout workflows by Copilot · Pull Request #36238 · github/gh-aw

Copilot · 2026-06-01T13:16:22Z

push_to_pull_request_branch already supports cross-repo checkouts, but prompt guidance was not explicit enough in multi-checkout layouts (e.g., editing/pushing from $GITHUB_WORKSPACE/github). This update makes the operational path explicit so agents reliably run git commands in the correct checkout before invoking the safe-output push tool.

Prompt guidance (agent-facing)
- Expanded actions/setup/md/safe_outputs_push_to_pr_branch.md with explicit multi-checkout instructions:
  - operate from the target repo checkout path
  - cd into that checkout before git operations
Prompt section behavior coverage
- Added focused assertions in pkg/workflow/unified_prompt_step_test.go to verify PR-comment prompt assembly:
  - guidance is injected when push-to-pull-request-branch is configured
  - guidance is not injected when it is not configured

**Multi-checkout workflows (`checkout:` with multiple repositories):**
- `push_to_pull_request_branch` operates on the checkout for the target repository.
- Run all `git` commands from that checkout directory before calling the tool.
- If needed, check out the PR branch locally from `origin/<pr-branch>` first.

Generated by 👨‍🍳 PR Sous Chef · gpt54 12.3M · ◷

Co-authored-by: dsyme <7204669+dsyme@users.noreply.github.com>

Copilot

Pull request overview

This PR clarifies how push_to_pull_request_branch should be used in multi-checkout GitHub Actions workflows and adds tests to ensure PR-comment prompt assembly includes (or omits) the push-to-PR-branch guidance based on configuration.

Changes:

Expanded safe_outputs_push_to_pr_branch.md with explicit guidance for multi-checkout layouts (operate from the target repo checkout and cd into it before running git).
Added assertions in unified_prompt_step_test.go to verify the PR-comment guidance section is injected only when push-to-pull-request-branch is configured.

Show a summary per file

File	Description
pkg/workflow/unified_prompt_step_test.go	Adds focused tests verifying conditional injection of push-to-PR-branch guidance for PR-comment workflows.
actions/setup/md/safe_outputs_push_to_pr_branch.md	Documents multi-checkout operational steps so agents run `git` in the correct checkout before pushing.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 2/2 changed files
Comments generated: 1

github-actions · 2026-06-01T15:43:36Z

✅ PR Code Quality Reviewer completed the code quality review.

github-actions · 2026-06-01T15:43:41Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #36238 does not have the 'implementation' label (has_implementation_label=false) and has only 44 new lines in business logic directories, which is below the 100-line threshold (requires_adr_by_default_volume=false). No custom design-gate config overrides apply.

github-actions · 2026-06-01T15:43:54Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

github-actions · 2026-06-01T15:44:59Z

🧪 Test Quality Sentinel completed test quality analysis.

github-actions

Skills-Based Review 🧠

Applied /zoom-out and /tdd — approving with two minor suggestions.

📋 Key Themes & Highlights

Key Themes

Example specificity: The hardcoded $GITHUB_WORKSPACE/github path is idiomatic to this repo and may mislead agents in other repos — a generic placeholder would travel better.
Event coverage: The positive test only exercises issue_comment; worth either expanding or commenting on whether other PR event types are intentionally excluded.

Positive Highlights

✅ Clear, concise documentation addition — directly addresses the silent failure mode described in the PR
✅ Solid complementary test pair: positive (guidance present) + negative (guidance absent) covers the injection contract cleanly
✅ Tight EnvVars assertion prevents accidental changes to the conditional expression

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 1.2M

github-actions

🔎 Code quality review by PR Code Quality Reviewer · sonnet46 1.5M

github-actions · 2026-06-01T15:51:18Z

🧪 Test Quality Sentinel Report

✅ Test Quality Score: 100/100 — Excellent

Analyzed 2 test scenario(s) across 1 modified test file: 2 design tests (behavioral contracts), 0 implementation tests, 0 guideline violations.

📊 Metrics & Test Classification (2 tests analyzed)

Metric	Value
New/modified tests analyzed	2 (sub-tests of 1 new `Test*` function)
✅ Design tests (behavioral contracts)	2 (100%)
⚠️ Implementation tests (low value)	0 (0%)
Tests with error/edge cases	1 (50%) — negative-path sub-test
Duplicate test clusters	0
Test inflation detected	No
🚨 Coding-guideline violations	0

Test Classification Details

Test	File	Classification	Issues Detected
`includes guidance when PR comment triggers and push-to-pr-branch is configured`	`pkg/workflow/unified_prompt_step_test.go:524`	✅ Design	None — verifies `ShellCondition`, event filter, and `EnvVars` content
`does not include guidance when push-to-pr-branch is not configured`	`pkg/workflow/unified_prompt_step_test.go:524`	✅ Design	None — negative path (absence of section)

Language Support

Tests analyzed:

🐹 Go (*_test.go): 2 sub-tests (unit — //go:build !integration)
🟨 JavaScript: 0 tests

Verdict

✅ Check passed. 0% of new tests are implementation tests (threshold: 30%). Build tag present (//go:build !integration). No mocks. All assertions include descriptive messages.

📖 Understanding Test Classifications

Design Tests (High Value) verify what the system does:

Assert on observable outputs, return values, or state changes
Cover error paths and boundary conditions
Would catch a behavioral regression if deleted
Remain valid even after internal refactoring

Implementation Tests (Low Value) verify how the system does it:

Assert on internal function calls (mocking internals)
Only test the happy path with typical inputs
Break during legitimate refactoring even when behavior is correct

Goal: Shift toward tests that describe the system's behavioral contract.

🧪 Test quality analysis by Test Quality Sentinel · sonnet46 1.2M · ◷

github-actions

✅ Test Quality Sentinel: 100/100. Test quality is excellent — 0% of new tests are implementation tests (threshold: 30%). Both sub-tests verify behavioral contracts, build tag is present, no mocks used, and all assertions include descriptive messages.

…o-pull-request

github-actions · 2026-06-01T16:00:58Z

@copilot please inspect the failing test and build-wasm checks after the branch refresh, then summarize the remaining blockers.

Generated by 👨‍🍳 PR Sous Chef · gpt54 12.3M · ◷

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…ded test coverage - Replace repo-specific path example with generic description - Replace ambiguous cd instruction with subshell/pushd guidance - Add pull_request_review_comment trigger test case - Add SafeOutputs: nil negative test case

Initial plan

c2b46ce

Copilot AI assigned Copilot and dsyme Jun 1, 2026

Copilot started work on behalf of dsyme June 1, 2026 13:16 View session

Copilot AI linked an issue Jun 1, 2026 that may be closed by this pull request

Needed explicit prompting for push-to-pull-request-branch in multi-repo checkout #36237

Closed

Add explicit multi-checkout guidance for push_to_pull_request_branch

f98c291

Co-authored-by: dsyme <7204669+dsyme@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Improve explicit prompting for push-to-pull-request-branch~~ Clarify push_to_pull_request_branch behavior for multi-checkout workflows Jun 1, 2026

Copilot finished work on behalf of dsyme June 1, 2026 13:33

Copilot AI requested a review from dsyme June 1, 2026 13:33

github-actions Bot mentioned this pull request Jun 1, 2026

[aw] No-Op Runs #36156

Open

Update safe_outputs_push_to_pr_branch.md

662f9bd

dsyme marked this pull request as ready for review June 1, 2026 15:01

Copilot AI review requested due to automatic review settings June 1, 2026 15:01

Copilot started reviewing on behalf of dsyme June 1, 2026 15:01 View session

Copilot AI reviewed Jun 1, 2026

View reviewed changes

Comment thread actions/setup/md/safe_outputs_push_to_pr_branch.md Outdated

github-actions Bot approved these changes Jun 1, 2026

View reviewed changes

Comment thread actions/setup/md/safe_outputs_push_to_pr_branch.md

Comment thread pkg/workflow/unified_prompt_step_test.go

github-actions Bot reviewed Jun 1, 2026

View reviewed changes

Comment thread pkg/workflow/unified_prompt_step_test.go

Comment thread actions/setup/md/safe_outputs_push_to_pr_branch.md Outdated

github-actions Bot approved these changes Jun 1, 2026

View reviewed changes

Merge branch 'main' into copilot/needed-explicit-prompting-for-push-t…

10f4e94

…o-pull-request

dsyme and others added 2 commits June 1, 2026 17:13

Potential fix for pull request finding

efa5914

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

github-actions Bot added the spam label Jun 1, 2026

github deleted a comment Jun 1, 2026

github-actions Bot added the ai-inspected label Jun 1, 2026

dsyme merged commit 774b186 into main Jun 1, 2026
32 checks passed

dsyme deleted the copilot/needed-explicit-prompting-for-push-to-pull-request branch June 1, 2026 17:03

github-actions Bot mentioned this pull request Jun 2, 2026

[docs] Update documentation for features from 2026-06-02 #36440

Closed

Conversation

Copilot AI commented Jun 1, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

github-actions Bot commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Key Themes

Positive Highlights

Uh oh!

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 1, 2026

🧪 Test Quality Sentinel Report

Test Classification Details

Language Support

Verdict

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Jun 1, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Jun 1, 2026 •

edited

Loading

github-actions Bot commented Jun 1, 2026 •

edited

Loading

github-actions Bot commented Jun 1, 2026 •

edited

Loading

github-actions Bot commented Jun 1, 2026 •

edited

Loading