Remove vestigial applyTo from parser validFields allowlist#36309
Merged
Conversation
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix inconsistency of applyTo between parser allowlist and schema
Remove vestigial Jun 1, 2026
applyTo from parser validFields allowlist
pelikhan
approved these changes
Jun 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens parser validation by removing the vestigial applyTo key from the included-frontmatter “valid fields” allowlist, so applyTo is no longer silently treated as an acceptable frontmatter field.
Changes:
- Removed
applyTofrom the allowlist used when collecting “unexpected” included-frontmatter fields. - Deleted now-obsolete unit test cases that asserted
applyTowas not filtered.
Show a summary per file
| File | Description |
|---|---|
| pkg/parser/include_processor.go | Removes applyTo from the set of included-frontmatter fields treated as “valid” for unexpected-field reporting. |
| pkg/parser/schema_utilities_test.go | Removes test cases that covered applyTo behavior that is no longer intended/supported. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applyTowas silently accepted by the parser'svalidFieldsallowlist but absent from the JSON schema and undocumented — any workflow withapplyTo:would pass parser validation without ever being schema-validated.Changes
pkg/parser/include_processor.go— Remove"applyTo": truefromcollectUnexpectedIncludedFrontmatterFields.applyTois vestigial: it was previously in the "silently ignored" list, co-promoted withdescriptiontovalidFields, but unlikedescriptionit was never added to the schema. Removing it means any workflow usingapplyTo:will now get a proper unknown-field validation error.pkg/parser/schema_utilities_test.go— Remove two test cases ("frontmatter with applyTo - no longer filtered") that documented the incomplete promotion transition rather than meaningful behavior.