[log] Add debug logging to 5 sparsely-logged Go files#36403
Merged
Conversation
Add meaningful debug log calls to five substantial pkg/ files that already declared a logger but barely used it, following the project's pkg:filename logger convention. All log arguments are side-effect-free reads of in-scope values (len() of collections, booleans, scalars). - cli:jsonworkflow_to_markdown — generation size/warnings, trigger and tool conversion outcomes - cli:audit_cross_run — MCP health, domain inventory, drain3 insight builds - cli:outcome_eval_generic — milestone/push-to-PR evaluation entry & PR state - workflow:on_needs_validation — on.needs target, github-app expression, and dependency-chain validation - parser:schema_validation — shared-workflow on-field validation result Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add debug logging to 5 sparsely-logged Go files
Summary
Adds diagnostic
Printflog statements across five Go files that previously had sparse or missing observability. No logic, signatures, or tests are changed.Changes
pkg/cli/audit_cross_run.gopkg/cli/jsonworkflow_to_markdown.gopkg/cli/outcome_eval_generic.gopkg/parser/schema_validation.goonfield validation entrypkg/workflow/on_needs_validation.goon.needstarget validation, GitHub App needs expression validation, dependency chain validationImplementation notes
auditCrossRunLog,jsonWorkflowLog,outcomeEvalGenericLog,schemaValidationLog,onNeedsValidationLog) — no new dependencies introduced.Printfformat strings that report counts, flags, and state values (e.g. number of items, boolean flags) to make traces actionable without requiring a debugger.Risk
None — logging only. Existing behaviour is entirely preserved.