Align max-turns integration test with current frontmatter schema semantics#36521
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
test(workflow): fix max-turns validation test for CI failure
Align max-turns integration test with current frontmatter schema semantics
Jun 2, 2026
Copilot created this pull request from a session on behalf of
pelikhan
June 2, 2026 20:02
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates TestMaxTurnsValidation to match current frontmatter schema behavior: max-turns must be a YAML integer (or a ${{ ... }} expression in allowed contexts), and numeric strings like "5" are invalid and should fail compilation.
Changes:
- Flip the
max-turns: "5"case from “expected success” to “expected failure”. - Rename the subtest to reflect the invalid-input intent.
- Adjust the YAML snippet for the invalid case to use the current top-level
max-turnsform (engine: claude,max-turns: ...).
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/max_turns_test.go |
Aligns the max-turns validation test expectation with the schema’s templatable_integer rules (reject numeric strings). |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was failing in
pkg/workflowbecauseTestMaxTurnsValidationstill treated a string literalmax-turnsvalue as valid. Current schema rules reject string literals formax-turnsand only accept numeric values (or expression-based forms in allowed contexts).Problem alignment
TestMaxTurnsValidationfrom a “valid string” expectation to an invalid-case expectation.invalid string max-turns).Behavior codified
max-turns: "5"withengine: claude, matching schema enforcement.Representative change