Fix: Add activation job to create_pull_request needs list

[Copilot]

The create_pull_request jobs reference needs.activation.outputs.comment_id and needs.activation.outputs.comment_repo for comment linking but were missing activation in their dependency list, causing 28 actionlint errors across 14 workflows.

Changes

• pkg/workflow/compiler_jobs.go: Add activation to the needs list when building create_pull_request jobs (line 193)
• 14 workflow lock files: Regenerated with updated dependency graph

Example

# Before
create_pull_request:
  needs:
    - agent
    - detection
  env:
    GH_AW_COMMENT_ID: ${{ needs.activation.outputs.comment_id }}  # ❌ undefined

# After  
create_pull_request:
  needs:
    - agent
    - activation  # ✅ added
    - detection
  env:
    GH_AW_COMMENT_ID: ${{ needs.activation.outputs.comment_id }}  # ✅ defined

Follows the pattern established in notify_comment.go which correctly includes both dependencies.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[task] Fix undefined activation job outputs in create_pull_request jobs</issue_title>
<issue_description>## Objective
Fix 22 actionlint errors across 11 workflows where create_pull_request jobs reference needs.activation.outputs but don't include activation in their needs dependency list.

Context

Part of discussion #3606 - Static Analysis Report findings. These workflows currently fail actionlint validation and will fail at runtime when trying to access activation outputs for PR comment linking.

Approach

For each affected workflow, add activation to the needs array in the create_pull_request job.

Current (BROKEN):

create_pull_request:
  needs:
    - agent
    - detection
  env:
    GH_AW_COMMENT_ID: ${{ needs.activation.outputs.comment_id }}  # ❌ activation not in needs

Fixed:

create_pull_request:
  needs:
    - activation  # ✅ Add this
    - agent
    - detection
  env:
    GH_AW_COMMENT_ID: ${{ needs.activation.outputs.comment_id }}  # ✅ Now accessible

Files to Modify

Edit these 11 workflow markdown files in .github/workflows/:

1. security-fix-pr.md (errors at lines 3659, 3660 in .lock.yml)
2. daily-doc-updater.md (errors at lines 3713, 3714)
3. go-logger.md (errors at lines 3832, 3833)
4. developer-docs-consolidator.md (errors at lines 4519, 4520)
5. github-mcp-tools-report.md (errors at lines 4341, 4342)
6. unbloat-docs.md (errors at lines 4731, 4732)
7. dictation-prompt.md (errors at lines 3884, 3885)
8. poem-bot.md (errors at lines 5911, 5912)
9. q.md (errors at lines 5298, 5299)
10. technical-doc-writer.md (errors at lines 5028, 5029)
11. tidy.md (errors at lines 4249, 4250)

Acceptance Criteria

• All 11 workflows have activation added to create_pull_request job's needs list
• Run make recompile to regenerate all .lock.yml files
• Run gh aw compile --actionlint - no errors about undefined properties
• Verify activation comment linking still works in test workflow
• All actionlint errors related to activation outputs are resolved
  Related to 🔍 Static Analysis Report - November 11, 2025 #3606

AI generated by Plan Command for discussion #3606</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes [task] Fix undefined activation job outputs in create_pull_request jobs #3651

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[Copilot]

Pull Request Overview

This PR fixes a bug where create_pull_request jobs referenced needs.activation.outputs.comment_id and needs.activation.outputs.comment_repo in their environment variables but did not declare activation in their needs dependency list, causing 28 actionlint errors across 14 workflows. The fix adds the missing dependency at the compiler level, ensuring all generated workflows have the correct dependency graph.

Key changes:

• Added activation to the needs list when building create_pull_request jobs in the compiler
• Updated the comment to document that activation is needed for comment linking
• Regenerated 14 workflow lock files with the corrected dependency graph

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

File	Description
pkg/workflow/compiler_jobs.go	Added activation to needs array and updated comment to document the dependency
.github/workflows/*.lock.yml (14 files)	Regenerated lock files with corrected dependency graph including activation --> create_pull_request

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.