Stop appending effective-token suffixes in default JavaScript-generated footers#37042
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
Remove effective tokens from generated JavaScript footers
Stop appending effective-token suffixes in default JavaScript-generated footers
Jun 5, 2026
Copilot created this pull request from a session on behalf of
pelikhan
June 5, 2026 02:47
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Removes “effective token” suffix text from the default JavaScript safe-output footer rendering so generated attribution lines are less noisy, while preserving {effective_tokens_suffix} support for custom templates.
Changes:
- Updated default footer generation in
messages_footer.cjsto stop appending effective-token suffixes forgetFooterMessage,getFooterAgentFailureIssueMessage, andgetFooterAgentFailureCommentMessage. - Updated
messages.test.cjsexpectations to reflect the new default footer output while keeping custom-template placeholder behavior covered.
Show a summary per file
| File | Description |
|---|---|
| actions/setup/js/messages_footer.cjs | Stops appending effective-token suffixes in default footer paths while keeping template placeholders available. |
| actions/setup/js/messages.test.cjs | Updates tests to assert default footers no longer include effective-token suffixes; custom template behavior remains tested. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
| }); | ||
|
|
||
| it("should preserve mini-tier gpt identifiers in footer suffixes", async () => { | ||
| it("should not include mini-tier model identifiers in default footer suffixes", async () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default footer generation in the JavaScript safe-output path was still appending effective-token text, which made generated attribution lines noisier than intended. This change removes effective-token suffixes from default footer text while keeping explicit token placeholders available for custom templates.
Footer rendering behavior
actions/setup/js/messages_footer.cjsto stop appending{effective_tokens_suffix}in default footer paths:getFooterMessage(...)(Generated by ...)getFooterAgentFailureIssueMessage(...)(Generated from ...)getFooterAgentFailureCommentMessage(...)(Generated from ...)Custom template compatibility
{effective_tokens_suffix}in configured custom footers continue to render token values.Spec-aligned test updates
actions/setup/js/messages.test.cjsexpectations to reflect that default generated footers no longer include effective-token suffixes.