fix(setup): include safe_outputs_mcp_arguments in safe-outputs copy list#37229
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Addressed in |
|
@copilot make sure the file is in the safe output MCP file list |
Confirmed in |
There was a problem hiding this comment.
Pull request overview
This PR updates several compiled “*.lock.yml” workflows to address a Safe Outputs MCP runtime dependency issue (missing safe_outputs_mcp_arguments.cjs at runtime) and to adjust cross-repo safe-outputs behavior.
Changes:
- Regenerates multiple workflow lockfiles (prompt/config heredoc IDs updated) as part of the setup fix rollout.
- Adds a “Build checkout manifest for safe-outputs handlers” step to the cross-repo smoke workflows.
- Updates embedded MCP scripts/tooling blocks in the affected lock workflows (auto-generated content).
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/smoke-update-cross-repo-pr.lock.yml | Adds checkout-manifest generation step; regenerates prompt/config heredocs. |
| .github/workflows/smoke-create-cross-repo-pr.lock.yml | Adds checkout-manifest generation step; regenerates prompt/config heredocs. |
| .github/workflows/smoke-copilot.lock.yml | Regenerates prompt/config heredocs and embedded MCP-scripts blocks. |
| .github/workflows/smoke-copilot-arm.lock.yml | Regenerates prompt/config heredocs and embedded MCP-scripts blocks. |
| .github/workflows/smoke-copilot-aoai-apikey.lock.yml | Regenerates prompt/config heredocs and embedded MCP-scripts blocks. |
| .github/workflows/daily-regulatory.lock.yml | Regenerates prompt/config heredocs and embedded MCP-scripts blocks. |
| .github/workflows/daily-performance-summary.lock.yml | Regenerates prompt/config heredocs and embedded MCP-scripts blocks. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 7/7 changed files
- Comments generated: 3
| - name: Build checkout manifest for safe-outputs handlers | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} | ||
| run: | |
| - name: Build checkout manifest for safe-outputs handlers | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} | ||
| run: | |
| - name: Build checkout manifest for safe-outputs handlers | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| set -euo pipefail | ||
| mkdir -p "${RUNNER_TEMP}/gh-aw" | ||
| manifest="${RUNNER_TEMP}/gh-aw/checkout-manifest.json" |
The
agentjob in run27048167917failed atStart Safe Outputs MCP HTTP Serverbecausesafe_outputs_mcp_server_http.cjscould not resolve./safe_outputs_mcp_arguments.cjsat runtime.Failure mode addressed
Cannot find module './safe_outputs_mcp_arguments.cjs'in${GH_AW_ROOT}/safeoutputs.Setup fix
safe_outputs_mcp_arguments.cjsis provided through the curatedSAFE_OUTPUTS_FILEScopy path inactions/setup/setup.sh.